-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcm_setup python conversion #602
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Matthew Thompson <[email protected]>
…iments are trivial zero diff
gcmpy/jinjafy.py
Outdated
@@ -0,0 +1,257 @@ | |||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if there is a better name for this file. The filename should reflect what it is used for - not what technology it uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly this file should not be included in this PR, it is mainly a helper script for me. No one else should need to ever run this.
@@ -0,0 +1,67 @@ | |||
import os, sys, platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"utility" is a bit vague. Possibly a more specific name could be thought of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree. Env and utility should probably be merged into a new script down the line. These scripts were kind of thrown together early on and desperately need to be updated.
The purpose of this PR is to fully rewrite gcm_setup in python, as a small start of a larger effort to refactor the GEOS codebase.
Some notes:
gcm_setup
has been uncharacteristically edited/expanded upon quite a bit this past year, so a lot of features have yet to be added (e.g. singularity sandbox, data atmosphere, etc.). In addition, some parts of the code may be outdated from the latest commit of the mainline script.gcm_setup
that previously had the syntax@foo
now look like{{ foo }}
.~\GEOSgcm\install\bin\gcmpy\scripts\
and run the commandpython gcm_setup.py