-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up mk_GEOSldasRestarts and process_rst.csh #551
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e72cf69
This branch is using mk_catchANDcnRestarts.x
weiyuan-jiang d76fbab
change components for testing purpose
weiyuan-jiang cc4cda2
set in_tilefile as string by default
weiyuan-jiang f2909f2
reverting components.yaml back to develop branch in anticipation of P…
gmao-rreichle abe3d18
Merge branch 'develop' into feature/wjiang/clean_mk_restarts
gmao-rreichle 347a88d
changed to python 3 and use remap_restarts
weiyuan-jiang 120d38f
change the script for processing restart
weiyuan-jiang 0a338cd
bug fix
weiyuan-jiang 2a3af9c
fix glob
weiyuan-jiang e7d2fa0
correct python3 division
weiyuan-jiang 795cf09
change chmod
weiyuan-jiang 3df4bc2
rm support for LDASsa restart. rm process_rst.csh
weiyuan-jiang 2640504
search vegrst
weiyuan-jiang b3aeb0e
change componet for test
weiyuan-jiang 45ec4c0
Revert "change componet for test"
gmao-rreichle fa7f594
reverting GMAO_Shared back to "main" branch in components.yaml in pre…
gmao-rreichle 1f51c48
fix typos in comments (ldas_setup)
gmao-rreichle f8828a7
extend FP restart dates
weiyuan-jiang e3c52a6
resolved merge conflict in CMakeLists.txt
gmao-rreichle e6994a3
Merge branch 'develop' into feature/wjiang/clean_mk_restarts. Resolve…
gmao-rreichle 17901e5
update catchcn restart dummy files
biljanaorescanin 4c85309
fix catchcn45 tile file
biljanaorescanin 664049a
missing else
biljanaorescanin f93bb94
no need for else
biljanaorescanin 3379fc0
else syntax error
biljanaorescanin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiyuan-jiang, @gmao-jkolassa:
If I'm guessing right, the current ldas_setup does not have information about a dummy restart file for CatchCNCLM45. It looks like the dummy restart files for the other model versions are all in the M09 tile space. @gmao-jkolassa, do you have an M09 restart for CatchCNCLM45 that could be used as a dummy restart here? If not, we could use the M36 restart from the LDAS_GLOBALCNCLM45 nightly test.
@weiyuan-jiang, please work with @gmao-jkolassa to implement a dummy CatchCNCLM45 restart in ldas_setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have an M09 restart file readily available, but I can generate one if that is preferred. Please let me know.
@weiyuan-jiang I will send you the path to an M36 restart that can be used if an M09 restart is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmao-jkolassa: I'll leave it up to you to decide if we need an M09 dummy restart or if the M36 restart from the nightly test case is sufficient. Note that this is just a dummy and meant to give users a start by providing a properly formatted restart. Users will need to do some spin-up (unless the dummy restart itself is spun up properly, in the same tile space, and for the desired restart date, which is not likely to ever happen).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is only meant to serve as a dummy restart with the understanding that some additional spin-up is necessary, I think it is fine to use the M36 restart file from the nightly test. I will work with @weiyuan-jiang to make sure it is copied to an accessible space.