Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remap_restarts.py: add command line option; move temporary directory to out_dir for merra2; add more test cases #276

Merged
merged 27 commits into from
Aug 29, 2022
Merged

remap_restarts.py: add command line option; move temporary directory to out_dir for merra2; add more test cases #276

merged 27 commits into from
Aug 29, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Jul 22, 2022 •
edited by gmao-rreichle
Loading

This PR further enhances the new "remap_restarts.py" utility:

Still missing: EASE-based test case, see #265 (comment)

@weiyuan-jiang weiyuan-jiang added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jul 22, 2022
@weiyuan-jiang weiyuan-jiang requested review from a team as code owners July 22, 2022 14:31
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner July 22, 2022 19:21
@weiyuan-jiang
Copy link
Contributor Author

@sdrabenh , I have tested this PR and it is working.

@gmao-rreichle gmao-rreichle changed the title move temporary directory to out_dir for merra2 remap_restarts.py: move temporary directory to out_dir for merra2 Jul 27, 2022
@gmao-rreichle gmao-rreichle changed the title remap_restarts.py: move temporary directory to out_dir for merra2 remap_restarts.py: add command line option; move temporary directory to out_dir for merra2 Jul 27, 2022
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner August 17, 2022 15:32
@weiyuan-jiang
Copy link
Contributor Author

@sdrabenh @mathomp4 This PR is ready. Would you please review it ?

@biljanaorescanin biljanaorescanin mentioned this pull request Aug 19, 2022
Merged
@weiyuan-jiang weiyuan-jiang changed the title remap_restarts.py: add command line option; move temporary directory to out_dir for merra2 remap_restarts.py: add command line option; move temporary directory to out_dir for merra2; add more test cases Aug 25, 2022
@gmao-rreichle gmao-rreichle mentioned this pull request Aug 26, 2022
Merged
@gmao-rreichle gmao-rreichle added the enhancement New feature or request label Aug 26, 2022
gmao-rreichle
gmao-rreichle approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@sdrabenh sdrabenh merged commit a5695a4 into main Aug 29, 2022
@sdrabenh sdrabenh deleted the feature/wjiang/improve_merra2 branch August 29, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-rreichle gmao-rreichle gmao-rreichle approved these changes

@sdrabenh sdrabenh sdrabenh approved these changes

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiyuan-jiang @mathomp4 @sdrabenh @gmao-rreichle