Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update n4zip to fix deprecated option #354

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Aug 7, 2024

As pointed out by @gmao-yzhu, when you run n4zip you get a big warning from NCO:

> /discover/nobackup/mathomp4/SystemTests/builds/AGCM/CURRENT/GEOSgcm/install-Release/bin/n4zip stock-2024Jul26-1day-c24-SLES15.geosgcm_prog.20000415_1800z.nc4
/discover/nobackup/mathomp4/SystemTests/builds/AGCM/CURRENT/GEOSgcm/install-Release/bin/n4zip: working on stock-2024Jul26-1day-c24-SLES15.geosgcm_prog.20000415_1800z.nc4  ...ncks: WARNING the ncks '-a', '--abc', and '--alphabetize' switches are misleadingly named because they turn-off the default alphabetization. These switches are deprecated as of NCO 4.7.1 and will soon be deleted. Instead, please use the new long options --no_abc, --no-abc, --no_alphabetize, or --no-alphabetize, all of which turn-off the default alphabetization.
 ok

So, to avoid this, we update the --abc to --no-alphabetize.

Also, add -f to the csh shebang. Always good practice.

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug labels Aug 7, 2024
@mathomp4 mathomp4 self-assigned this Aug 7, 2024
@mathomp4 mathomp4 requested review from a team as code owners August 7, 2024 11:41
@sdrabenh sdrabenh merged commit b0cf192 into main Sep 13, 2024
11 checks passed
@sdrabenh sdrabenh deleted the feature/mathomp4/fix-up-n4zip branch September 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants