Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc14: Add int to main in makdep.c #356

Merged
merged 2 commits into from
Aug 19, 2024
Merged

gcc14: Add int to main in makdep.c #356

merged 2 commits into from
Aug 19, 2024

Conversation

mathomp4
Copy link
Member

Building GEOS with GCC 14 found an issue where makdep.c did not declare main as an int. GCC 14 no longer allows implicit int main it seems.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 15, 2024
@mathomp4 mathomp4 self-assigned this Aug 15, 2024
@mathomp4 mathomp4 requested review from a team as code owners August 15, 2024 20:02
zhaobin74
zhaobin74 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@zhaobin74 zhaobin74 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long overdue. Thanks for the fix.

@mathomp4 mathomp4 requested a review from sdrabenh August 19, 2024 15:44
@sdrabenh sdrabenh merged commit 413dfeb into main Aug 19, 2024
11 checks passed
@sdrabenh sdrabenh deleted the bugfix/mathomp4/test-gcc14-run branch August 19, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaobin74 zhaobin74 zhaobin74 approved these changes

@sdrabenh sdrabenh sdrabenh approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathomp4 @zhaobin74 @sdrabenh