Merge pull request #3170 from GEOS-ESM/feature/tclune/#3169-allow-dup…

…licate-dimensions

Fixes #3169 - handle duplicate dimensions

pfio/FileMetadata.F90

@@ -123,11 +123,20 @@ subroutine add_dimension(this, dim_name, extent, unusable, rc)
       class (FileMetadata), target, intent(inout) :: this
       character(len=*), intent(in) :: dim_name
       integer, intent(in) :: extent
-
       class (KeywordEnforcer), optional, intent(in) :: unusable
       integer, optional, intent(out) :: rc
 
-      call this%dimensions%insert(dim_name, extent)
+      integer :: existing_extent
+
+      if (.not. this%has_dimension(dim_name)) then
+         call this%dimensions%insert(dim_name, extent)
+         _RETURN(_SUCCESS)
+      end if
+
+      ! Otherwise verify consistency
+      existing_extent = this%get_dimension(dim_name)
+      _ASSERT(extent == existing_extent,'FileMetadata::add_dimension() - dimension already exists with different extent.')
+
       _RETURN(_SUCCESS)
       _UNUSED_DUMMY(unusable)
    end subroutine add_dimension

pfio/tests/Test_FileMetadata.pf

@@ -49,6 +49,26 @@ contains
 
    end subroutine test_get_dimension
 
+   @test
+   subroutine test_fail_add_existing_dim_with_mismatch()
+      type (FileMetadata) :: cf
+
+      call cf%add_dimension('x', 10)
+      call cf%add_dimension('x', 11)
+
+      @assertExceptionRaised('FileMetadata::add_dimension() - dimension already exists with different extent.')
+
+   end subroutine test_fail_add_existing_dim_with_mismatch
+
+   @test
+   subroutine test_add_duplicate_dimension()
+      type (FileMetadata) :: cf
+
+      call cf%add_dimension('x', 10)
+      call cf%add_dimension('x', 10)
+
+   end subroutine test_add_duplicate_dimension
+
    @test
    subroutine test_get_dimensions()
       type (FileMetadata), target :: cf