-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field allocation for SSI capability #2471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his allows explicit specification of indexflag required by the new MAPL field split functionality. This functionality allows a clean way to create a new field from an exiting field where the new field is a 'slice' of the existing field with the slicing index being that of the trailing ungiridded dim of the existing field
…ith just _RC in line with our new convention
…o assess the SIngle System Image capability of ESMF that is needed or the 'mixed' hybrid approach for GEOS GCM where only the dyncore is hybrid MPI/OpenMP and everything else stays only MPI, both sides using the same number of total PEs
…__RCplus_VERIFY_with__RC
I think this is meant to go to |
mathomp4
reviewed
Dec 5, 2023
mathomp4
reviewed
Dec 5, 2023
mathomp4
added
the
🚫 Contingent - DNA
Do Not Approve (DNA). These changes are contingent on other PRs
label
Dec 20, 2023
mathomp4
removed
the
🚫 Contingent - DNA
Do Not Approve (DNA). These changes are contingent on other PRs
label
Dec 21, 2023
NOTE: I think the CI issues are due to CI quirks grabbing the other |
tclune
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocate gridded fields to use the pinflag option needed for the Single System Image (SSI) capability.
Description
In subroutine MAPL_FieldAllocCommit, gridded fields are allocated from scratch with the pinflag option such that the SSI capability of ESMF can be used as necessary. Using thsi capability is essential for the mixed hybrid code with the dyncore hybrid MPI/OpenMP and the rest of GEOS GCM using only MPI.
Related Issue
Motivation and Context
Mixed hybrid code
How Has This Been Tested?
Zero diff through c720
Stock g5_module but with ESMA-Baselibs-7.16.0 (at least ESMF 8.6.0)
Types of changes
Checklist: