Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mapl3 dev/dec23 #2495

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Feature/mapl3 dev/dec23 #2495

merged 4 commits into from
Dec 18, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Dec 17, 2023

Tested MAPL3 on OSX nag only. But should be small cleanup changes - nothing risky.

@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related labels Dec 17, 2023
@tclune tclune requested review from a team as code owners December 17, 2023 21:30
@tclune tclune changed the base branch from main to release/MAPL-v3 December 17, 2023 21:31
@mathomp4
Copy link
Member

Intel seems to be throwing a build error:

/__w/MAPL/MAPL/geom_mgr/latlon/LatLonGeomFactory_smod.F90(279): error #6405: The same named entity from different modules and/or program units cannot be referenced.   [KEYWORDENFORCER]
      class(KeywordEnforcer), optional, intent(in) :: unusable
------------^
/__w/MAPL/MAPL/geom_mgr/latlon/LatLonGeomFactory_smod.F90(276): error #6404: This name does not have a type, and must have an explicit type.   [UNUSABLE]
   module function make_file_metadata(this, geom_spec, unusable, chunksizes, rc) result(file_metadata)
-------------------------------------------------------^

But oddly GNU was fine. That is...interesting.

@tclune tclune merged commit 7704dbf into release/MAPL-v3 Dec 18, 2023
9 of 18 checks passed
@mathomp4 mathomp4 deleted the feature/mapl3-dev/Dec23 branch December 18, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants