Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3267 refactor variable spec #3271

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Fixes #3267 refactor variable spec #3271

merged 7 commits into from
Jan 3, 2025

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Dec 25, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Dec 25, 2024
@tclune tclune requested a review from a team as a code owner December 25, 2024 15:34
@tclune
Fix for "mirror" ungridded
0881269 
UngriddedDimsAspect is a rare case where an Aspect has a sensible
default value (none) but absences must still be considered to be
mirror.   This commit corrects an inconsistency in the treatment which
was not affecting the tests before.
@tclune tclune changed the base branch from main to release/MAPL-v3 December 26, 2024 15:45
@tclune tclune requested a review from atrayano December 26, 2024 15:45
darianboggs
darianboggs approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@darianboggs darianboggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tclune tclune merged commit 7f99e3a into release/MAPL-v3 Jan 3, 2025
41 checks passed
@tclune tclune deleted the feature/tclune/#3267-refactor-variable-spec branch January 3, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darianboggs darianboggs darianboggs approved these changes

@atrayano atrayano Awaiting requested review from atrayano

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @darianboggs