Bugfix/wdboggs/i3248 test max action #3275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulation Add Time Accumulation for ESMF_Field objects to MAPL3
…verload_macro Change '_FUNCN' to '_FUNC' which is the correct macro appearing in files in field subdirectory
…oordinates. Vertical staggering is set to 'VERTICAL_STAGGER_CENTER'
…hakrab/vertical-regridding
…idding Feature/pchakrab/vertical regridding
…ture/pchakrab/vertical-regridding
…ortran tests can pass I am fairly certain that the issue comes from the line 'spec%vertical_grid = this%vertical_grid' in FieldSpec::adapt_vertical_grid when copying from a ModelVerticalGrid to a FixedLevelsVerticalGrid
FieldBundle. - introduced FieldBundleType_Flag to check whether a bundle is a bracket bundle. - introduced FieldundleInfo.F90 - analog to FieldInfo.F90 Changes unfortunately leaked into lots of other code.
Co-authored-by: Darian Boggs <[email protected]>
…-overload-write StateItemSpec overload write
…hakrab/vertical-regridding
…m:GEOS-ESM/MAPL into feature/wdboggs/add_run_dt_to_field_specs
…field_specs Feature/wdboggs/add run dt to field specs
…ble-gridcomp-follow-up
…urable-gridcomp-follow-up Follow up for #3231
- Some simple tests have been implemented for generic Aspect logic. - Some subclasses have been implemented - but not tested. - High level logic has been added to exercise aspects, but it is not currently activated as the default aspect list is empty. - Next step is to convert adapters to aspects one at a time and see if things still work. Undoubtedly this will expose problems with new logic. - Everything compiles and tests pass, such as they are.
…-aspect-base-class Fixes #3247 - Initial implementation of StateItemAspect.
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, 😲 Non 0 Diff, 🔧 Github Actions. Please add one so that the PR can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
Fixes the bug with MaxAction which was in the tests.
Related Issue
#3248