Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/wdboggs/i3248 test max action #3276

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Bugfix/wdboggs/i3248 test max action #3276

merged 7 commits into from
Jan 6, 2025

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Fixes the bug with MaxAction which was in the tests.

Related Issue

#3248

@darianboggs darianboggs added 🪲 Bug Something isn't working 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Jan 2, 2025
@darianboggs darianboggs self-assigned this Jan 2, 2025
@darianboggs darianboggs requested a review from a team as a code owner January 2, 2025 19:50
tclune
tclune approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_accumulate_R4 is awfully long. Hopefully others won't need to modify.

@darianboggs darianboggs merged commit 2f6f781 into release/MAPL-v3 Jan 6, 2025
39 checks passed
@darianboggs darianboggs deleted the bugfix/wdboggs/I3248_test_max_action branch January 6, 2025 14:21
@darianboggs darianboggs mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@darianboggs darianboggs

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bug Something isn't working 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darianboggs @tclune