Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/atrayano/history start stop #3278

Merged
merged 26 commits into from
Jan 6, 2025

Conversation

atrayano
Copy link
Contributor

@atrayano atrayano commented Jan 2, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Adds optional start_date and start_time for each collection to disable output before the specified time.

Related Issue

Fixes #3277

@atrayano atrayano requested a review from a team as a code owner January 2, 2025 20:48
@atrayano atrayano added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 2, 2025
@atrayano
Copy link
Contributor Author

atrayano commented Jan 2, 2025

I forgot that I started off a branch for Scott. Now my branch is merged with develop and ready for review

CHANGELOG.md Outdated Show resolved Hide resolved
@mathomp4 mathomp4 requested a review from bena-nasa January 3, 2025 14:00
@mathomp4
Copy link
Member

mathomp4 commented Jan 3, 2025

I cleaned up the CHANGELOG a little (added a dash). I might wait until @bena-nasa is back for him to give the ultimate approval.

I also think we might try a squash-and-merge with this, due to the history. Shouldn't hurt.

@tclune tclune self-requested a review January 6, 2025 19:42
tclune
tclune previously approved these changes Jan 6, 2025
@atrayano atrayano merged commit 8a14993 into develop Jan 6, 2025
48 checks passed
@atrayano atrayano deleted the feature/atrayano/history_start_stop branch January 6, 2025 20:31
@sdrabenh sdrabenh restored the feature/atrayano/history_start_stop branch January 13, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants