fixes #3280 #3281
Merged
fixes #3280 #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bena-nasa
added
🎁 New Feature
tclune
previously approved these changes
Jan 6, 2025
bena-nasa
removed
the
🚫 Contingent - DNA
tclune
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my quick proposal to fix the UFS issue with the masking, would be easy to back port. We set the destination mask values as an attribute in the grid, if they don't no masking applied. If they are there, we can mask all the values set in the grid
The other way to fix this would for for @metdyn to use dynamic masking in the sampler.
Either way @metdyn should probably test this with geostationary sampler.
I've made this contingent if we want a different solution but put it here for debate.
Types of change(s)
Checklist
make tests)Description
Related Issue