Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Aspect for Frequency/Accumulation #3286

Merged
merged 16 commits into from
Jan 10, 2025
Merged

Add Aspect for Frequency/Accumulation #3286

merged 16 commits into from
Jan 10, 2025

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

The abstract StateItemAspect type creates ExtensionAction objects to accomplish coupling between source and destination objects. This PR adds a FrequencyAspect that produces an AccumulationAction for a source and a destination Field.

@darianboggs darianboggs added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Jan 7, 2025
@darianboggs darianboggs requested a review from tclune January 7, 2025 03:08
@darianboggs darianboggs self-assigned this Jan 7, 2025
@darianboggs
Copy link
Contributor Author

I have pushed the current development of FrequencyAspect for review. It is not integrated into the broader Aspect system yet.

@darianboggs
Copy link
Contributor Author

Currently, it passes the MAPL unit tests for ifort, nagfor, and gfortran on bucy.

@tclune
Copy link
Collaborator

tclune commented Jan 7, 2025

No that is not what we mean by INSTANTANEOUS. By that term we mean that we take whatever the current export value is - regardless of when it was last created. In MAPL2 the world is divided into "instantaneous" and "average" (with variants on that). We have no special case for "same time step".

tclune
tclune requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested.

@darianboggs darianboggs marked this pull request as ready for review January 10, 2025 18:07
@darianboggs darianboggs requested a review from a team as a code owner January 10, 2025 18:07
tclune
tclune approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty clean, but I did not have a chance for a deep read.

But I want it merged before my PR (to save @darianboggs the difficulty)

@darianboggs darianboggs merged commit 2256498 into release/MAPL-v3 Jan 10, 2025
41 checks passed
@darianboggs darianboggs deleted the feature/wdboggs/add_accumulation_aspect branch January 13, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@darianboggs darianboggs

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darianboggs @tclune