Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Configurable gridcomp to read k values from config file #3300

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Allow Configurable gridcomp to read k values from config file #3300

merged 8 commits into from
Jan 10, 2025

Conversation

pchakraborty
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Configurable GridComp can now read k-values from config file. Also moved the the routine get_bundle_from_state_ from generic3g/RestartHandler.F90 to state/StateGet.F90 with MAPL_StateGet as the interface.

Related Issue

@pchakraborty pchakraborty requested a review from a team as a code owner January 10, 2025 03:46
@pchakraborty pchakraborty self-assigned this Jan 10, 2025
@pchakraborty pchakraborty added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Jan 10, 2025
tclune
tclune reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to ask. What are "k-values"?

@pchakraborty
Copy link
Contributor Author

I have to ask. What are "k-values"?

I'll change that to vertical_profile

@tclune tclune merged commit 4bb6d82 into release/MAPL-v3 Jan 10, 2025
39 checks passed
@tclune tclune deleted the feature/pchakrab/configurable-gridcomp-read-k-values branch January 10, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@pchakraborty pchakraborty

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchakraborty @tclune