Updates to allow GEOS to build without MKL #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This set of PRs is to allow GEOS to build without MKL. Note that it currently does this by making RRTMGP unusable if MKL is not found. This is not ideal, but it's a first attempt.
For unknown reasons, even though, with MKL loaded, MKL_LIBRARIES is the same as LAPACK_LIBRARIES save for a `-lm -ldl`, the answers are non-zero-diff. So, if MKL_FOUND, use MKL_LIBRARIES to maintain zero-diff
tclune
approved these changes
Jul 28, 2020
|
I have not played with it myself. Just seen it mentioned in the man pages occasionally e.g.: https://cmake.org/cmake/help/latest/command/add_library.html#alias-libraries |
This was referenced Sep 2, 2020
mathomp4
added
0 diff
tclune
previously approved these changes
Sep 4, 2020
bena-nasa
previously approved these changes
Sep 4, 2020
tclune
previously approved these changes
Sep 4, 2020
mathomp4
added
0 diff structural
tclune
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of PRs is to allow GEOS to build without MKL. Note that it currently does this by making RRTMGP unusable if MKL is not found. This is not ideal, but it's a first attempt.
Should be taken in concert with:
GEOS-ESM/GEOSgcm_GridComp#321GEOS-ESM/ESMA_cmake#115ETA: Turns out thanks to CMake knowledge of @tclune this is no longer true! Since each component specifies what they need, they are now independent!