refactor: move GEWISDB syncing logic to gewisdb-sync-service

GEWIS · Jan 19, 2025 · 732e5a9 · 732e5a9
1 parent b160ab6
commit 732e5a9
Show file tree

Hide file tree

Showing 11 changed files with 458 additions and 599 deletions.
diff --git a/package.json b/package.json
@@ -22,7 +22,6 @@
     "lint": "eslint package.json src test --ext .js --ext .ts",
     "lint-fix": "npm run lint -- --fix",
     "typeorm": "node --require ts-node/register ./node_modules/typeorm/cli.js",
-    "cli": "ts-node ./src/gewis/service/cli-service.ts",
     "predocs:dev": "typedoc",
     "typedoc": "typedoc",
     "docs:dev": "vitepress dev docs",

diff --git a/src/cron.ts b/src/cron.ts
@@ -37,6 +37,7 @@ import DefaultRoles from './rbac/default-roles';
 import LdapSyncService from './service/sync/user/ldap-sync-service';
 import { UserSyncService } from './service/sync/user/user-sync-service';
 import UserSyncManager from './service/sync/user/user-sync-manager';
+import GewisDBSyncService from './gewis/service/gewisdb-sync-service';
 
 class CronApplication {
   logger: Logger;
@@ -109,16 +110,10 @@ async function createCronTasks(): Promise<void> {
     syncServices.push(ldapSyncService);
   }
 
-  // TODO move to GewisDBSyncService
-  // if (process.env.GEWISDB_API_KEY && process.env.GEWISDB_API_URL && process.env.ENABLE_GEWISDB_SYNC) {
-  //   await GewisDBService.syncAll();
-  //   const syncGewis = cron.schedule('41 4 * * *', async () => {
-  //     logger.debug('Syncing users with GEWISDB.');
-  //     await GewisDBService.syncAll();
-  //     logger.debug('Synced users with GEWISDB.');
-  //   });
-  //   application.tasks.push(syncGewis);
-  // }
+  if (process.env.GEWISDB_API_KEY && process.env.GEWISDB_API_URL && process.env.ENABLE_GEWISDB_SYNC) {
+    const gewisDBSyncService = new GewisDBSyncService();
+    syncServices.push(gewisDBSyncService);
+  }
 
   if (syncServices.length !== 0) {
     const syncManager = new UserSyncManager(syncServices);

diff --git a/src/entity/server-setting.ts b/src/entity/server-setting.ts
@@ -32,6 +32,7 @@ export interface ISettings {
   jwtExpiryDefault: number;
   jwtExpiryPointOfSale: number;
   maintenanceMode: boolean;
+  allowGewisSyncDelete: boolean;
 }
 
 /**

diff --git a/src/gewis/service/cli-service.ts b/src/gewis/service/cli-service.ts
diff --git a/src/gewis/service/gewisdb-service.ts b/src/gewis/service/gewisdb-service.ts