fix: balance cache invalidation on transaction creation #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, balance cache is cleared when a transaction is created/updated/ deleted for a user. However, balance cache should not be invalidated when creating a transaction. Creating a transaction is an action forward; new balance is just the sum of balance cache + all new transactions for that user. Thus, no need to remove it. Invalidating it is also bad for performance, as balance has to be calculated on the fly until next balance cache calculation (cronjob). This removes balance cache invalidation for transaction creations.
JustSamuel
approved these changes
Feb 13, 2025
I cannot answer the first question (see introduction in 3b24477), but it is updated/repopulated as expected at 01:14: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, balance cache is cleared when a transaction is created/updated/ deleted for a user. However, balance cache should not be invalidated when creating a transaction.
Creating a transaction is an action forward; new balance is just the sum of balance cache + all new transactions for that user. Thus, no need to remove it. Invalidating it is also bad for performance, as balance has to be calculated on the fly until next balance cache calculation (cronjob).
This removes balance cache invalidation for transaction creations.
Here confirmation of the old behaviour:
After creating a transaction:
Related issues/external references
GH-466
Types of changes