-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: post refactoring invoice ui #335
Conversation
Will this also include creating invoices? I heard from Robin that #304 will be closed without merging. |
234b052
to
bd0dfd9
Compare
@SuperVK id prefer to do invoice creation in a different PR to reduce scope. |
2b0a573
to
70745a0
Compare
@JustSamuel is this ready for review? Also for creating invoices? |
9ca3afa
to
a631298
Compare
7bcfdc6
to
cfa5987
Compare
I have had the beautiful opertunity to test my own code whilst making ALL the intro invoices, I also let the BACPM try it and the first impressions were "yoah dat lijkt wel te werken ofnie", so I think this is fine to merge so that I can go do something else with my life. @SuperVK please review, I will do the translations when I Get rid of this hangover. |
e75e33d
to
ebfb097
Compare
926752f
to
6216e3d
Compare
6216e3d
to
834deda
Compare
Nice, I dont think I have much comments right now besides the translations obv |
834deda
to
7b5e718
Compare
translations have been fixed |
7b5e718
to
74f6863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lekker gewerkt!
apps/dashboard/src/modules/financial/components/invoice/create/InvoiceCreate.vue
Outdated
Show resolved
Hide resolved
74f6863
to
59e6d2b
Compare
59e6d2b
to
45274dc
Compare
Description
Now the UI adheres to the new setup: the user is able to change the amount of the invoice transfer and is warned if these do not match. Translations are left until the translation PR is merge.
Related issues/external references
Types of changes