[Feat] 연동된 피그마 계정 조회, 연동 해제 기능 구현 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
iiqcov
approved these changes
Nov 14, 2024
| @@ -36,13 +38,20 @@ public class Figma extends BaseTimeEntity { | |||
| @Column(nullable = false) | |||
| private String figmaUserId; | |||
|
|
|||
| @Column(nullable = true) | |||
There was a problem hiding this comment.
nullable = true 는 기본 설정이라서 추가를 안해도 괜찮을 것 같습니다!
| public List<FigmaAccountResponse> getFigmaAccount() { | ||
| final Member currentMember = memberUtil.getCurrentMember(); | ||
| List<Figma> figmaList = figmaRepository.findByMemberAndDeletedAtIsNull(currentMember); | ||
| if (figmaList.isEmpty()) { |
There was a problem hiding this comment.
처음 사이트에 구글 로그인을 한 경우 피그마 계정이 없을 수 있으니 예외 처리를 하지 않는 건 어떨까요?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 관련 이슈
💡 작업내용
1. 연동된 피그마 계정 조회
2. 피그마 계정 연동 해제 기능 구현
📸 스크린샷(선택)
📝 기타