-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Testing #233
Merged
Introduce Testing #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koebi
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
looks good so far 👍
My main issue is regarding the setup (conda + mamba + pip is too diverse), and one issue with the test itself.
This reverts commit 55706bf.
merydian
commented
Aug 21, 2024
As python is python, both `pyaml` and `pyyaml` exist, the former being mainly used for pretty-printing. As we don't print anything, we can depend on `pyyaml` instead.
koebi
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch may introduce testing.
Contents on the
common
andutils
directories undergo unit-tests. Contents ofgui
are testet with an integration test that utilizes a mocked QGis interface. Each of the plugins' processing algorithms is integration tested, directly testing their respectiveprocessAlgorithm
method.Locally tests can be run using an anaconda setup, the process of which is described in the Readme file.
On Github Actions, the QGis versions 3.16, 3.22 and the latest versions are testes on, using the docker images from QGis itself.