Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress test for unlock after certification #2998

Open
tadhg-ohiggins opened this issue Dec 14, 2023 · 4 comments
Open

Cypress test for unlock after certification #2998

tadhg-ohiggins opened this issue Dec 14, 2023 · 4 comments
Assignees
Labels

Comments

@tadhg-ohiggins
Copy link
Contributor

We need Cypress coverage for the unlock icon that shows up after a user hits the “ready for certification” button (but before any further certification happens).

This means bringing a submission through to the point where that button gets pressed, but then going back to /audit/ and verifying that the unlock icon and link to the unlock page are present.

Ensuring that the lock goes away and that the submission is editable after the unlock flow would also be good.

@github-project-automation github-project-automation bot moved this to Triage in FAC Dec 14, 2023
@danswick danswick added the eng label Dec 20, 2023
@danswick danswick moved this from Triage to Backlog in FAC Dec 20, 2023
@jadudm jadudm moved this from Backlog to Available in FAC Jan 3, 2024
@eazapata23 eazapata23 self-assigned this Jan 25, 2024
@eazapata23
Copy link
Member

Given user clicks on unlock

Image

And user is taken to unlock-after-certification

Image

At this point, the test would involve the user going back to /audit/ to verify the Unlock icon and link are present? Is this right?

Image

@eazapata23 eazapata23 moved this from Available to In Progress in FAC Jan 25, 2024
@eazapata23
Copy link
Member

@tadhg-ohiggins does this sound about right?

@tadhg-ohiggins
Copy link
Contributor Author

tadhg-ohiggins commented Jan 26, 2024

After they hit “Unlock submission”, the test would involve going back to /audit/ and verifying that the status is now “In Progress”, since that's the status unlocking moves a submission to.

@eazapata23
Copy link
Member

Progress so far..

Screen.Recording.2024-01-26.at.12.55.27.PM.mov

bit of trickery i've encountered before is selecting from the table the right associated audit, not sure how the table populates or orders the audits

@eazapata23 eazapata23 moved this from In Progress to For Review in FAC Feb 5, 2024
@eazapata23 eazapata23 linked a pull request Feb 26, 2024 that will close this issue
14 tasks
@eazapata23 eazapata23 moved this from For Review to In Progress in FAC Mar 6, 2024
@eazapata23 eazapata23 moved this from In Progress to Done in FAC Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants