Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PR-required actions on ready_for_review #83

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Jan 21, 2025

Currently, actions are not triggered for PRs that are automatically opened to update the caddy binary. This addresses that by:

  • Opening those PRs in draft mode
  • Updating the actions triggers to run after a person marks the automated PR as "ready for review"

There are other options to trigger the actions required to actually merge the PRs with our branch protections, but this seemed the least likely to cause longer-term issues around token ownership.

@rahearn rahearn requested review from a team January 21, 2025 14:40
@rahearn rahearn self-assigned this Jan 21, 2025
Copy link

@pauldoomgov pauldoomgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahearn rahearn merged commit ffcaf5c into main Jan 22, 2025
3 checks passed
@rahearn rahearn deleted the update-actions-triggers branch January 22, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants