Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1356 Add staging and prod branches to snyk file #1381

Merged
merged 1 commit into from
Jul 18, 2024
Merged

#1356 Add staging and prod branches to snyk file #1381

merged 1 commit into from
Jul 18, 2024

Conversation

kkrug
Copy link
Contributor

@kkrug kkrug commented Jul 17, 2024 •
edited by jdonis
Loading

Description

Add staging and production branches to snyk file

Related Issues

#1952

Changes Made

  • Add staging and production to branches section of snyk file

Screenshots (if applicable)

N/A

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.

@kkrug kkrug added this to the Sprint 07/16/24 milestone Jul 17, 2024
@kkrug kkrug linked an issue Jul 17, 2024 that may be closed by this pull request
Snyk setup for Challenge_gov #1356
Closed
1 task
@kkrug kkrug requested a review from jdonis July 17, 2024 13:40
@kkrug kkrug self-assigned this Jul 17, 2024
jdonis
jdonis approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@jdonis jdonis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkrug Do we need to add Snyk configuration to Staging?

@jdonis jdonis merged commit c0842d3 into dev Jul 18, 2024
3 checks passed
@jdonis jdonis deleted the 1356-add-branches-snyk branch July 18, 2024 14:48
@kkrug
Copy link
Contributor Author

kkrug commented Jul 18, 2024

@kkrug Do we need to add Snyk configuration to Staging?
@jdonis No, the single yml file will take care of all branches mentioned in the 'branches' section of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonis jdonis jdonis approved these changes

Assignees

@kkrug kkrug

Labels
None yet
Projects
None yet
Milestone
Sprint 07/30/24
Development

Successfully merging this pull request may close these issues.

Snyk setup for Challenge_gov
3 participants
@kkrug @jdonis @r-bartlett-gsa