Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1360] New user role: Evaluator #1392

Merged
merged 8 commits into from
Sep 12, 2024
Merged

[1360] New user role: Evaluator #1392

merged 8 commits into from
Sep 12, 2024

Conversation

cpreisinger
Copy link
Contributor

@cpreisinger cpreisinger commented Jul 26, 2024 •
edited by stepchud
Loading

Description

Adds evaluator role and related functions and tests

Related Issues

#1360
#1390 - May eventually add to this PR

Changes Made

  • Add evaluator role
  • Add evaluator checking functions
  • Add tests
  • Update and add tests

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.

@cpreisinger cpreisinger added this to the Sprint 07/30/24 milestone Jul 26, 2024
@cpreisinger cpreisinger self-assigned this Jul 26, 2024
@cpreisinger
Merge branch 'dev' of github.com:GSA/Challenge_gov into 1360/new-user…
ac91a2f 
…-role-evaluator

* 'dev' of github.com:GSA/Challenge_gov:
  #1315 Definition of Done checklist template
@r-bartlett-gsa r-bartlett-gsa linked an issue Jul 26, 2024 that may be closed by this pull request
New user role: Evaluator #1360
Closed
39 tasks
@stepchud stepchud changed the base branch from dev to eval-main July 31, 2024 15:05
stepchud
stepchud reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and seems to be working correctly. just a question about the yarn packages.

assets/yarn.lock Show resolved Hide resolved
@cpreisinger
Merge branch 'eval-main' of github.com:GSA/Challenge_gov into 1360/ne…
cc644e0 
…w-user-role-evaluator

* 'eval-main' of github.com:GSA/Challenge_gov:
  Configure SSL option for database
  Set up eval space portal deploy
@cpreisinger
Merge branch '1360/new-user-role-evaluator' of github.com:GSA/Challen…
72fe44b 
…ge_gov into 1360/new-user-role-evaluator

* '1360/new-user-role-evaluator' of github.com:GSA/Challenge_gov:
stepchud
stepchud approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@cpreisinger cpreisinger merged commit e80e28b into eval-main Sep 12, 2024
2 checks passed
@cpreisinger cpreisinger deleted the 1360/new-user-role-evaluator branch September 12, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepchud stepchud stepchud approved these changes

Assignees

@cpreisinger cpreisinger

Labels
None yet
Projects
None yet
Milestone
Sprint 09/10/24
Development

Successfully merging this pull request may close these issues.

New user role: Evaluator
4 participants
@cpreisinger @stepchud @r-bartlett-gsa @danivovich