Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging to Production #1495

Merged
merged 23 commits into from
Dec 30, 2024
Merged

Staging to Production #1495

merged 23 commits into from
Dec 30, 2024

Conversation

kkrug
Copy link
Contributor

@kkrug kkrug commented Dec 30, 2024 •
edited
Loading

Description

Staging to Production

Related Issues

#1390

Changes Made

  • Non gov access changes
  • Dependancy updates

Screenshots (if applicable)

[Include screenshots to visually demonstrate changes, if relevant.]

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.
  • Build has been approved for deployment in CircleCI.

jairoanaya and others added 20 commits November 8, 2024 16:43
@jairoanaya
Fix issue of non-gov accessing the submission
c573741
@jairoanaya
Fix format issue
22689e1
@jairoanaya
Removed Challenge Manager Banner from Challenges Page
56cb551
@kkrug
Merge pull request #1469 from GSA/1390-non-gov-access-to-information-…
8d41494 
…challenge-managers-from-staging

1390 non gov access to information challenge managers from staging
@jairoanaya
Removed Challenge Manager Banner from Wizard Page
fbe8bcf
@kkrug
Merge pull request #1471 from GSA/1390-non-gov-access-to-information-…
1f91cb5 
…challenge-managers-from-staging

Removed Challenge Manager Banner from Wizard Page
@jairoanaya
Centralize non-gov challenge manager processing and tracking function…
c1030b7 
…s on Security and Security Logs.
@jairoanaya
Fix typo
2cfdb37
@jairoanaya
Fix issue with struct and passing test
c2d5ce9
@kkrug
Merge pull request #1474 from GSA/1390-non-gov-access-to-information-…
eb01ddf 
…challenge-managers-from-staging

1390 non gov access to information challenge managers from staging
@jairoanaya
Fix missing reference and admin access bug
92538fc
@jairoanaya
Fix lint issue.
0191dca
@jdonis
Merge branch 'staging' into 1390-non-gov-access-to-information-challe…
5065fb9 
…nge-managers-from-staging
@jdonis
Merge pull request #1477 from GSA/1390-non-gov-access-to-information-…
ce58606 
…challenge-managers-from-staging

Fix missing reference and admin access bug
@jairoanaya
Fix accesibility issue report 2536
da65889
@kkrug
Merge pull request #1478 from GSA/2065-pages-accessibility-report-fix…
81470f0 
…es---2536

Fix accesibility issue report 2536
@jairoanaya
Dependabots resolved - by removing unused components and updating Eli…
1ff05d6 
…xir Packges
@jairoanaya
Fix testing file
37b6609
@kkrug
Merge pull request #1484 from GSA/1426-challenge_gov-dependabot-alert…
97af865 
…s-from-staging-v2

1426 challenge gov dependabot alerts from staging v2
@kkrug
Update pull_request_template.md
efe7738
@kkrug kkrug added this to the Sprint 01/14/25 milestone Dec 30, 2024
@kkrug kkrug requested review from jdonis and jairoanaya December 30, 2024 16:32
@kkrug kkrug linked an issue Dec 30, 2024 that may be closed by this pull request
Non-gov access to information (Challenge Managers) #1390
Closed
35 tasks
@r-bartlett-gsa r-bartlett-gsa linked an issue Dec 30, 2024 that may be closed by this pull request
Challenge_gov Dependabot alerts #1426
Closed
3 tasks
jairoanaya
jairoanaya approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@jairoanaya jairoanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks Ok.

@jairoanaya jairoanaya merged commit 432296a into production Dec 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairoanaya jairoanaya jairoanaya approved these changes

@jdonis jdonis Awaiting requested review from jdonis

Assignees

@kkrug kkrug

Labels
None yet
Projects
None yet
Milestone
Sprint 12/31/24
Development

Successfully merging this pull request may close these issues.

Challenge_gov Dependabot alerts Non-gov access to information (Challenge Managers)
4 participants
@kkrug @jairoanaya @r-bartlett-gsa @jdonis