Skip to content

Commit

Permalink
Adjust asset pipeline
Browse files Browse the repository at this point in the history
Issues found in deploy to cloud due to conflicting asset pipelines, etc.

Move to propshaft, js and css bundling, isolate uswds build
  • Loading branch information
danivovich committed Jul 30, 2024
1 parent 41b28a8 commit 7e4350f
Show file tree
Hide file tree
Showing 488 changed files with 792 additions and 7,959 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ jobs:
install-yarn: true
- node/install-packages:
pkg-manager: yarn
- run: npx gulp compile
- run: echo -e $DEV_PRIVATE_KEY > dev_key.pem
- run: echo -e $DEV_PUBLIC_CERT > dev_cert.pem
- run: echo 'export CF_PASSWORD=$CF_PASSWORD_DEV' >> $BASH_ENV
Expand Down
14 changes: 4 additions & 10 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,16 @@ ruby "3.2.4"
# Bundle edge Rails instead: gem "rails", github: "rails/rails", branch: "main"
gem "rails", "~> 7.1.3", ">= 7.1.3.4"

# The original asset pipeline for Rails [https://github.com/rails/sprockets-rails]
gem "sprockets-rails"

# Use postgresql as the database for Active Record
gem "pg"

# Use the Puma web server [https://github.com/puma/puma]
gem "puma", ">= 5.0"

# Use JavaScript with ESM import maps [https://github.com/rails/importmap-rails]
gem "importmap-rails"
# Use simple asset pipeline
gem "propshaft", "~> 0.9.0"
gem "cssbundling-rails", "~> 1.4"
gem "jsbundling-rails", "~> 1.3"

# Hotwire's SPA-like page accelerator [https://turbo.hotwired.dev]
gem "turbo-rails"
Expand Down Expand Up @@ -76,8 +75,3 @@ group :test do
gem 'rspec_junit_formatter'
gem 'simplecov'
end

gem "cssbundling-rails", "~> 1.4"

# Use Sass to process CSS
gem "sassc-rails"
38 changes: 10 additions & 28 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ GEM
concurrent-ruby (1.3.3)
connection_pool (2.4.1)
crass (1.0.6)
cssbundling-rails (1.4.0)
cssbundling-rails (1.4.1)
railties (>= 6.0.0)
date (3.3.4)
debug (1.9.2)
Expand All @@ -111,26 +111,20 @@ GEM
docile (1.1.5)
drb (2.2.1)
erubi (1.13.0)
ffi (1.17.0-aarch64-linux-gnu)
ffi (1.17.0-arm64-darwin)
ffi (1.17.0-x86_64-darwin)
ffi (1.17.0-x86_64-linux-gnu)
foreman (0.88.1)
globalid (1.2.1)
activesupport (>= 6.1)
i18n (1.14.5)
concurrent-ruby (~> 1.0)
importmap-rails (2.0.1)
actionpack (>= 6.0.0)
activesupport (>= 6.0.0)
railties (>= 6.0.0)
io-console (0.7.2)
irb (1.14.0)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
jbuilder (2.12.0)
actionview (>= 5.0.0)
activesupport (>= 5.0.0)
jsbundling-rails (1.3.1)
railties (>= 6.0.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
logger (1.6.0)
Expand Down Expand Up @@ -171,6 +165,11 @@ GEM
ast (~> 2.4.1)
racc
pg (1.5.6)
propshaft (0.9.0)
actionpack (>= 7.0.0)
activesupport (>= 7.0.0)
rack
railties (>= 7.0.0)
psych (5.1.2)
stringio
public_suffix (6.0.0)
Expand Down Expand Up @@ -257,14 +256,6 @@ GEM
parser (>= 3.3.1.0)
ruby-progressbar (1.13.0)
rubyzip (2.3.2)
sassc (2.4.0)
ffi (~> 1.9)
sassc-rails (2.1.2)
railties (>= 4.0.0)
sassc (>= 2.0)
sprockets (> 3.0)
sprockets-rails
tilt
selenium-webdriver (4.23.0)
base64 (~> 0.2)
logger (~> 1.4)
Expand All @@ -276,19 +267,11 @@ GEM
json (>= 1.8, < 3)
simplecov-html (~> 0.10.0)
simplecov-html (0.10.2)
sprockets (4.2.1)
concurrent-ruby (~> 1.0)
rack (>= 2.2.4, < 4)
sprockets-rails (3.5.1)
actionpack (>= 6.1)
activesupport (>= 6.1)
sprockets (>= 3.0.0)
stimulus-rails (1.3.3)
railties (>= 6.0.0)
stringio (3.1.1)
strscan (3.1.0)
thor (1.3.1)
tilt (2.3.0)
timeout (0.4.1)
turbo-rails (2.0.6)
actionpack (>= 6.0.0)
Expand Down Expand Up @@ -326,18 +309,17 @@ DEPENDENCIES
cssbundling-rails (~> 1.4)
debug
foreman
importmap-rails
jbuilder
jsbundling-rails (~> 1.3)
pg
propshaft (~> 0.9.0)
puma (>= 5.0)
rails (~> 7.1.3, >= 7.1.3.4)
rspec-rails
rspec_junit_formatter
rubocop
sassc-rails
selenium-webdriver
simplecov
sprockets-rails
stimulus-rails
turbo-rails
tzinfo-data
Expand Down
2 changes: 2 additions & 0 deletions Procfile.dev
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
web: env RUBY_DEBUG_OPEN=true bin/rails server
css: yarn build:css --watch
js: yarn build --watch
uswds: npx gulp watch
9 changes: 0 additions & 9 deletions app/assets/config/manifest.js

This file was deleted.

596 changes: 596 additions & 0 deletions app/assets/images/challenge-logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 0 additions & 8 deletions app/assets/stylesheets/application.sass.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1 @@
// Entry point for your Sass build
// 1. Load your project's USWDS settings configuration
@forward "../uswds/_uswds-theme.scss";

// 2. Load USWDS source code
@forward "uswds/_index.scss";

// 3. Load theme customizations
@forward "../uswds/_uswds-theme-custom-styles.scss"
5 changes: 0 additions & 5 deletions app/assets/stylesheets/styles.css

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/stylesheets/styles.css.map

This file was deleted.

2 changes: 1 addition & 1 deletion app/assets/uswds/_uswds-theme-custom-styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ i.e.
----------------------------------------
*/

// @use "uswds-core" as *;
@use "uswds-core" as *;
7 changes: 3 additions & 4 deletions app/assets/uswds/_uswds-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ in the form $setting: value,
----------------------------------------
*/

// @use "uswds-core" as *;
@use "uswds-core" with (
$theme-font-path: "./assets/fonts",
$theme-image-path: "./assets/images",
);
$theme-image-path: "images",
$theme-font-path: "fonts"
)
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
10 changes: 0 additions & 10 deletions app/assets/uswds/images/checkbox-indeterminate-alt.svg

This file was deleted.

10 changes: 0 additions & 10 deletions app/assets/uswds/images/checkbox-indeterminate.svg

This file was deleted.

Binary file removed app/assets/uswds/images/circle-124.png
Binary file not shown.
1 change: 0 additions & 1 deletion app/assets/uswds/images/circle-gray-20.svg

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/uswds/images/correct8-alt.svg

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/uswds/images/correct8.svg

This file was deleted.

Binary file removed app/assets/uswds/images/favicons/favicon-114.png
Binary file not shown.
Binary file removed app/assets/uswds/images/favicons/favicon-144.png
Binary file not shown.
Binary file removed app/assets/uswds/images/favicons/favicon-16.png
Binary file not shown.
Binary file removed app/assets/uswds/images/favicons/favicon-192.png
Binary file not shown.
Binary file removed app/assets/uswds/images/favicons/favicon-40.png
Binary file not shown.
Binary file removed app/assets/uswds/images/favicons/favicon-57.png
Binary file not shown.
Binary file removed app/assets/uswds/images/favicons/favicon-72.png
Binary file not shown.
Binary file removed app/assets/uswds/images/favicons/favicon.ico
Binary file not shown.
Binary file removed app/assets/uswds/images/favicons/favicon.png
Binary file not shown.
1 change: 0 additions & 1 deletion app/assets/uswds/images/file-excel.svg

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/uswds/images/file-pdf.svg

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/uswds/images/file-video.svg

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/uswds/images/file-word.svg

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/uswds/images/file.svg

This file was deleted.

Binary file removed app/assets/uswds/images/hero.jpg
Binary file not shown.
Binary file removed app/assets/uswds/images/hero.webp
Binary file not shown.
1 change: 0 additions & 1 deletion app/assets/uswds/images/icon-dot-gov.svg

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/uswds/images/icon-https.svg

This file was deleted.

Binary file removed app/assets/uswds/images/loader.gif
Binary file not shown.
1 change: 0 additions & 1 deletion app/assets/uswds/images/loader.svg

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/uswds/images/lock.svg
Diff not rendered.
Binary file removed app/assets/uswds/images/logo-img.png
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/sprite.svg
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/us_flag.svg
Diff not rendered.
Binary file removed app/assets/uswds/images/us_flag_small.png
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/add--white.svg
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/arrow_back--white.svg
Diff not rendered.
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/check--blue-60v.svg
Diff not rendered.
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/close--white.svg
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/error--white.svg
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/info--white.svg
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/launch--white.svg
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/remove--white.svg
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/search--white.svg
Diff not rendered.
1 change: 0 additions & 1 deletion app/assets/uswds/images/usa-icons-bg/warning--white.svg
Diff not rendered.
Loading

0 comments on commit 7e4350f

Please sign in to comment.