291 | Reduce arguments initialized in sort and filter service

app/controllers/phases_controller.rb

@@ -18,9 +18,11 @@ def submissions
     @submissions = SortAndFilterService.new(
       @submissions,
       params,
-      @not_started,
-      @in_progress,
-      @completed
+      {
+        not_started: @not_started,
+        in_progress: @in_progress,
+        completed: @completed
+      }
     ).sort_and_filter
 
     @filtered_count = @submissions.unscope(:group).distinct.count(:id)

app/helpers/evaluations_helper.rb

@@ -4,7 +4,8 @@
 module EvaluationsHelper
   Score = Struct.new(:raw_score, :formatted_score, :display_score)
 
-  def evaluator_score(assignment) # individual evaluator score
+  # individual evaluator score
+  def evaluator_score(assignment)
     score = display_score(assignment)
     return Score.new(0, "0", "N/A") if score == 'N/A'
 

app/services/sort_and_filter_service.rb

@@ -2,12 +2,12 @@
 
 # This service handles sort and filtering submissions.
 class SortAndFilterService
-  def initialize(submissions, params, not_started, in_progress, completed)
+  def initialize(submissions, params, submission_statuses = {})
     @submissions = submissions
     @params = params
-    @not_started = not_started
-    @in_progress = in_progress
-    @completed = completed
+    @not_started = submission_statuses[:not_started]
+    @in_progress = submission_statuses[:in_progress]
+    @completed = submission_statuses[:completed]
   end
 
   def sort_and_filter