#26 Eval footer #113
#26 Eval footer #113
Conversation
stepchud
force-pushed
the
26/eval-footer
branch
from
3e09731 to
c877a07
Compare
There was a problem hiding this comment.
I was going to leave some minor UI feedback but it took me a while to play around with the styles and would take longer to explain everything so I added 5b3c862 instead. I think this is close enough to match the mockups. @bilalhankins can you test the responsiveness of this out in your local browser and see if you notice anything else that needs to be fixed?
|
I tested and the responsiveness is way better than the changes i have locally. The only thing i saw was the space between the GSA logo and the right side of the screen on the mobile view. I tried to see if i could play with the css and eliminate the whitespace. I dont think it is too big of an issue tbh |
cool, I think it's fixed now |
| describe "GET /" do | ||
| before { get "/" } | ||
|
|
||
| it_behaves_like "a page with footer content" |
There was a problem hiding this comment.
the internal app links won't work yet but the external ones will. we can go ahead and add all the links now while we build those internal pages.
copied these from the production site at https://www.challenge.gov
Co-authored-by: Stephen Chudleigh <[email protected]>
Co-authored-by: Stephen Chudleigh <[email protected]>
Co-authored-by: Stephen Chudleigh <[email protected]>
|
WAVE report: |
Created footer layout
Added icons/logos to assets
Mobile responsiveness
Desktop View:
Mobile View:
#26