Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[158] Add role-based permission check to routes #174

Merged
merged 13 commits into from
Sep 30, 2024

Conversation

cpreisinger
Copy link
Contributor

Main tasks
#158

Role specific sub tasks
#13
#16
#23

…ator-role-access

* 'dev' of github.com:GSA/Challenge_platform:
  Documentation update
  Set mailer defaults
  Add swaks and smtp stream proxy
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some feedback mostly on the specs

.codeclimate.yml Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
spec/requests/dashboard_request_spec.rb Show resolved Hide resolved
spec/requests/evaluation_forms_spec.rb Outdated Show resolved Hide resolved
spec/requests/evaluation_forms_spec.rb Outdated Show resolved Hide resolved
spec/requests/evaluations_spec.rb Outdated Show resolved Hide resolved
spec/requests/evaluations_spec.rb Outdated Show resolved Hide resolved
spec/requests/manage_submissions_spec.rb Outdated Show resolved Hide resolved
spec/requests/manage_submissions_spec.rb Outdated Show resolved Hide resolved
spec/spec_helper.rb Outdated Show resolved Hide resolved
…latform into 16/evaluator-role-access

* '16/evaluator-role-access' of github.com:GSA/Challenge_platform:
  style fixes
  fix rubocop 2
  fix rubocop
  rubocop
  evaluation form request specs
  challenge with phase helper spec
  evaluation forms request spec
  allow rendering of blank forms in list view
  fix request spec
  add by_user scope to EvaluationForm
  remove requirements for challenge id and challenge phase
  update icons
  remove status and publication date from views
  remove status and publication date
  remove clone
  UI updates
  list view, clone action
  evaluation form model, migration, CRUD
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cpreisinger cpreisinger merged commit cb330f5 into dev Sep 30, 2024
11 checks passed
@cpreisinger cpreisinger deleted the 16/evaluator-role-access branch September 30, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants