-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[158] Add role-based permission check to routes #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator-role-access * 'dev' of github.com:GSA/Challenge_platform: Documentation update Set mailer defaults Add swaks and smtp stream proxy
This was
linked to
issues
Sep 24, 2024
Closed
a4ed186
to
2981190
Compare
stepchud
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some feedback mostly on the specs
…ator-role-access * 'dev' of github.com:GSA/Challenge_platform: fix wave errors on header
stepchud
reviewed
Sep 27, 2024
…latform into 16/evaluator-role-access * '16/evaluator-role-access' of github.com:GSA/Challenge_platform: style fixes fix rubocop 2 fix rubocop rubocop evaluation form request specs challenge with phase helper spec evaluation forms request spec allow rendering of blank forms in list view fix request spec add by_user scope to EvaluationForm remove requirements for challenge id and challenge phase update icons remove status and publication date from views remove status and publication date remove clone UI updates list view, clone action evaluation form model, migration, CRUD
stepchud
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main tasks
#158
Role specific sub tasks
#13
#16
#23