Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[291 & 292] Evaluation Status Details #321

Merged
merged 49 commits into from
Jan 8, 2025
Merged

[291 & 292] Evaluation Status Details #321

merged 49 commits into from
Jan 8, 2025

Conversation

emmabjj
Copy link
Contributor

@emmabjj emmabjj commented Dec 13, 2024

Related tickets: #291 #292

Add evaluation status details in the submission index for a challenge phase.

Details added in this PR:

  • Evaluator Name
    • Evaluator name is highlighted in red if recused
  • Evaluation Status tag for the evaluator's progress on the evaluation for that submission (recused, completed, in progress, not started)
  • Average score for the evaluations of that submission
  • Judging status checkbox functionality (eligible for evaluation & selected to advance)
    • These checkboxes are disabled under these conditions
      • Eligible for evaluation is disabled when:
        • the submission has evaluators assigned to it
      • Selected to advance is disabled when:
        • not eligible for evaluation
        • when there are evaluations assigned to the submission that are incomplete
        • when there are no evaluators assigned to the submission.
Screenshot 2024-12-13 at 10 20 16 AM Screenshot 2024-12-13 at 10 20 29 AM Screenshot 2024-12-13 at 10 21 02 AM

@emmabjj emmabjj self-assigned this Dec 13, 2024
@emmabjj emmabjj requested a review from stepchud December 13, 2024 20:40
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/17/24 milestone Dec 13, 2024
This was linked to issues Dec 13, 2024
Add evaluation status details to the list #291
Closed
Update submission Eligible for Evaluation / Selected to Advance from list view #292
Closed
stepchud
stepchud reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing but I wanted to send the feedback on the update route so you have it sooner

app/controllers/phases_controller.rb Outdated Show resolved Hide resolved
app/controllers/submissions_controller.rb Outdated Show resolved Hide resolved
stepchud
stepchud reviewed Dec 17, 2024
View reviewed changes
app/models/submission.rb Outdated Show resolved Hide resolved
stepchud and others added 18 commits January 6, 2025 15:21
@stepchud
convert #order_by_average_score class method to scope, make #average_…
2370d1f 
…score method public
@stepchud
update error message, fix linter
06ad73e
@stepchud
linting
f45288e
@stepchud
reformat to combine specs with the same name
b5a0123
@stepchud
linting
1c377b8
@stepchud
remove unused helper methods
52ed1e3
@emmabjj
291 | Fix test by mocking and adding an evaluation
b27170a
@emmabjj
291 | Fix merge conflict, combine submission index
a32c5e1
@stepchud
fix submission_details_spec
3c79563
@stepchud
Merge remote-tracking branch 'origin/291_evaluation_status_details' i…
e414fd8 
…nto 291_evaluation_status_details
@stepchud
expect UI state
07c0e5b
@stepchud
fix merge conflict
3ab2cd6
@emmabjj
291 | Make submission table rows consistent in size
e220288
@emmabjj
291 | Add format scoring
0be31fa
@emmabjj
291 | Remove redundant evaluation inclusion
4477db3
@emmabjj
291 | Move sort and filter logic to service
f144573
@emmabjj
291 | Add option to skip bullet warnings on RSpec tests
b4a06ee
@emmabjj
291 | Reduce arguments initialized in sort and filter service
8515494
@emmabjj emmabjj requested a review from stepchud January 7, 2025 20:01
stepchud
stepchud requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thing for average_score and then I think we can ship

app/views/phases/_submissions_table_rows.html.erb Show resolved Hide resolved
@emmabjj emmabjj requested a review from stepchud January 7, 2025 23:46
stepchud
stepchud approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ❤️ 💙 💛 💜

@emmabjj emmabjj merged commit 00a8652 into dev Jan 8, 2025
11 checks passed
@emmabjj emmabjj deleted the 291_evaluation_status_details branch January 8, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepchud stepchud stepchud approved these changes

Assignees

@emmabjj emmabjj

Labels
None yet
Projects
None yet
Milestone
Sprint 01/14/25
3 participants
@emmabjj @stepchud @r-bartlett-gsa