[285] Adjust Challenge Phase index query for Evaluators

app/controllers/evaluations_controller.rb

@@ -10,8 +10,11 @@ class EvaluationsController < ApplicationController
   before_action :set_phase, only: [:submissions]
 
   def index
-    @challenges = Challenge.joins(phases: :challenge_phases_evaluators).
-      where(challenge_phases_evaluators: { user_id: current_user.id }).
+    @challenges = Challenge.joins(phases: { submissions: :evaluator_submission_assignments }).
+      where(evaluator_submission_assignments: {
+        user_id: current_user.id,
+        status: [:assigned, :recused]
+      }).
       includes(phases: [:evaluation_form]).
       distinct
   end
@@ -171,4 +174,4 @@ def evaluation_params
   end
 end
 # TODO: Remove this after above refactor
-# rubocop:enable all
+# rubocop:enable all

spec/requests/evaluations_spec.rb

@@ -62,6 +62,61 @@
         expect(response).to redirect_to(ENV.fetch("PHOENIX_URI", nil))
       end
     end
+
+    context "when logged in as an evaluator" do
+      let(:evaluator) { create_and_log_in_user(role: 'evaluator') }
+
+      let(:challenge) { create(:challenge, title: "Challenge with Assignments", is_multi_phase: false) }
+      let(:phase) { challenge.phases.first }
+
+      let(:other_challenge) { create(:challenge, title: "Challenge without Assignments", is_multi_phase: false) }
+      let(:other_phase) { other_challenge.phases.first }
+
+      before do
+        ChallengePhasesEvaluator.create!(challenge: challenge, phase: phase, user: evaluator)
+        ChallengePhasesEvaluator.create!(challenge: other_challenge, phase: other_phase, user: evaluator)
+      end
+
+      it "only shows challenges with assigned or recused submissions" do
+        assigned_submission = create(:submission, phase: phase, challenge: challenge)
+        create(:evaluator_submission_assignment,
+          submission: assigned_submission,
+          evaluator: evaluator,
+          status: :assigned
+        )
+
+        recused_submission = create(:submission, phase: phase, challenge: challenge)
+        create(:evaluator_submission_assignment,
+          submission: recused_submission,
+          evaluator: evaluator,
+          status: :recused
+        )
+
+        unassigned_submission = create(:submission, phase: phase, challenge: challenge)
+        create(:evaluator_submission_assignment,
+          submission: unassigned_submission,
+          evaluator: evaluator,
+          status: :unassigned
+        )
+
+        recused_unassigned_submission = create(:submission, phase: phase, challenge: challenge)
+        create(:evaluator_submission_assignment,
+          submission: recused_unassigned_submission,
+          evaluator: evaluator,
+          status: :recused_unassigned
+        )
+
+        get evaluations_path
+
+        expect(response.body).to include(challenge.title)
+        expect(response.body).not_to include(other_challenge.title)
+        expect(response.body.scan(/data-label="Challenge Title"/).count).to eq(1)
+        expect(response.body).to have_css('td[data-label="Assigned to me"]')
+        expect(response.body).to have_css('td[data-label="Assigned to me"]', text: '2')
+        expect(response.body).to have_css('td[data-label="Remaining to evaluate"]')
+        expect(response.body).to have_css('td[data-label="Remaining to evaluate"]', text: '2')
+      end
+    end
   end
 
   describe "GET /evaluations/:id/submissions" do