Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7] Add Brakeman and Code Climate #37

Merged
merged 16 commits into from
Jul 22, 2024
Merged

Conversation

cpreisinger
Copy link
Contributor

There are a few things attempting to be configured in this PR as more CI and code infrastructure dependencies were brought up

#7
#35

@cpreisinger cpreisinger self-assigned this Jul 15, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 07/16/24 milestone Jul 15, 2024
This was linked to issues Jul 15, 2024
@stepchud stepchud self-requested a review July 15, 2024 14:33
…latform into 7/add-brakeman-and-code-climate

* '20/connect-elixir-app-db' of github.com:GSA/Challenge_platform:
  20 Add pg gem, database.yml, and schema.rb
@cpreisinger cpreisinger force-pushed the 7/add-brakeman-and-code-climate branch from 1152838 to 5d0e553 Compare July 19, 2024 17:41
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, left a comment on rubocop config

Comment on lines +11 to +13
- 'config/**/*'
- 'config.ru'
- 'db/**/*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure we want to ignore all config/ and db/ subdirectories, or any specific ones?

@cpreisinger cpreisinger merged commit 454d18c into dev Jul 22, 2024
9 checks passed
@cpreisinger cpreisinger deleted the 7/add-brakeman-and-code-climate branch July 23, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snyk setup for challenge_platform Add Brakeman and Code Climate
3 participants