Adjust Asset Pipeline #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues found in deploy to cloud due to conflicting asset pipelines, etc. Move to propshaft, js and css bundling, isolate uswds build
stepchud
reviewed
Jul 30, 2024
| @@ -362,7 +362,7 @@ | |||
| <div class="grid-container"> | |||
| <div class="usa-footer__logo grid-row grid-gap-2"> | |||
| <div class="grid-col-auto"> | |||
| <img class="usa-footer__logo-img" src="/assets/images/logo-img.png" alt="" /> | |||
| <img width="1024" class="usa-footer__logo-img" src="<%= image_path("challenge-logo.svg") %>" alt="" /> | |||
stepchud
reviewed
Jul 30, 2024
| 1. Install rubygems dependencies with `bundle install` | ||
| 1. Install nodejs dependencies `yarn install` | ||
| 1. Set up your uswds files in the build directory `npx gulp copyAssets` | ||
| 1. Setup the database `rake db:create`, note that postgres must be running for this to work |
There was a problem hiding this comment.
do we need to note the shared DB with Phoenix here? if a user has their DB created and seeded on that repo, they don't need this step
There was a problem hiding this comment.
Probably, but I figured we'd see how things shake out and update this pretty often
stepchud
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
ig this is only relevant for sprockets?
|
|
||
| 1. Install rubygems dependencies with `bundle install` | ||
| 1. Install nodejs dependencies `yarn install` | ||
| 1. Set up your uswds files in the build directory `npx gulp copyAssets` |
There was a problem hiding this comment.
🎉 this also fixes bin/rake for me, which was blowing up on the double linker error (not this particular file, the whole PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues found in deploy to cloud due to conflicting asset pipelines, etc.
Move to propshaft since we don't need the power of sprockets
Simplify asset builds by using jsbundling and esbuilt and cssbundling with sass node
Also isolate uswds to its own part of the assets folder, with its output configured to place into the builds folder where propshaft can pick it up.
Also validated that everything works with static assets from public/assets after asset:precompile