Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scale-web-template #4609

Merged
merged 3 commits into from
Feb 7, 2024
Merged

add scale-web-template #4609

merged 3 commits into from
Feb 7, 2024

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Feb 6, 2024

Pull Request

Related to

About

  • add scale-web-template.yml to be called from catalog-app
  • modify bin/check-and-renew to add scale capability
  • add bin/scale_calculate.sh for scale desicion

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Any dependent PRs needed?

@FuhuXia FuhuXia requested a review from a team February 6, 2024 22:13
@FuhuXia FuhuXia mentioned this pull request Feb 6, 2024
Merged
@FuhuXia FuhuXia marked this pull request as draft February 6, 2024 22:38
btylerburton
btylerburton previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 nice solution!

@FuhuXia FuhuXia marked this pull request as ready for review February 7, 2024 14:24
@FuhuXia FuhuXia requested review from a team and btylerburton February 7, 2024 14:24
@Jin-Sun-tts Jin-Sun-tts merged commit e9fbdeb into main Feb 7, 2024
@Jin-Sun-tts Jin-Sun-tts deleted the scale branch February 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jin-Sun-tts Jin-Sun-tts Jin-Sun-tts approved these changes

@btylerburton btylerburton Awaiting requested review from btylerburton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FuhuXia @btylerburton @Jin-Sun-tts