-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add inventory item constraints #1063
Conversation
a481c20
to
cdf4545
Compare
Co-Authored-By: A.J. Stein <[email protected]>
Co-Authored-By: A.J. Stein <[email protected]>
ceab238
to
1399f9c
Compare
Co-authored-by: Gabeblis <[email protected]>
Co-authored-by: Gabeblis <[email protected]>
…agic/fedramp-automation into inventory-item-constraints
commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064)
commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064)
@wandmagic This needs a rebase |
commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064)
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NON-BLOCKING: Functionally, the constraints look good to me. Minor aesthetic / formatting (e.g.., indentations, etc) could be adjusted later, but this is non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
commit 7c6b0f2 Merge: f10ace6 26f4f19 Author: ~ . ~ <[email protected]> Date: Fri Jan 10 11:49:42 2025 -0500 Merge branch 'canary' of https://github.com/wandmagic/fedramp-automation into canary commit f10ace6 Author: ~ . ~ <[email protected]> Date: Wed Jan 8 11:06:00 2025 -0500 use latest server build commit d7af65c Author: ~ . ~ <[email protected]> Date: Tue Jan 7 22:21:48 2025 -0500 hotfix missing expect tag commit ee65d47 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 17:17:54 2025 -0500 use preview versions of oscal tools commit b9ca17a Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit f556138 Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests commit 60ba7f7 Author: wandmagic <[email protected]> Date: Fri Jan 10 11:15:47 2025 -0500 add inventory item constraints (GSA#1063) * add inventory item constraints * update example file Co-Authored-By: A.J. Stein <[email protected]> * improve scan type constraint * massage constraints * improve constraint content * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update fedramp-external-constraints.xml * Update fedramp-external-constraints.xml * Squashed commit of the following: commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) * Squashed commit of the following: commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) * Squashed commit of the following: commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) --------- Co-authored-by: A.J. Stein <[email protected]> Co-authored-by: Gabeblis <[email protected]> commit 5e3f386 Author: wandmagic <[email protected]> Date: Fri Jan 10 09:25:07 2025 -0500 make build (GSA#1080) commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 26f4f19 Author: ~ . ~ <[email protected]> Date: Wed Jan 8 11:06:00 2025 -0500 use latest server build commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit dd20034 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 22:21:48 2025 -0500 hotfix missing expect tag commit b4d3df5 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 17:17:54 2025 -0500 use preview versions of oscal tools commit 719cf2c Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit ec7affc Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests
commit 7c6b0f2 Merge: f10ace6 26f4f19 Author: ~ . ~ <[email protected]> Date: Fri Jan 10 11:49:42 2025 -0500 Merge branch 'canary' of https://github.com/wandmagic/fedramp-automation into canary commit f10ace6 Author: ~ . ~ <[email protected]> Date: Wed Jan 8 11:06:00 2025 -0500 use latest server build commit d7af65c Author: ~ . ~ <[email protected]> Date: Tue Jan 7 22:21:48 2025 -0500 hotfix missing expect tag commit ee65d47 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 17:17:54 2025 -0500 use preview versions of oscal tools commit b9ca17a Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit f556138 Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests commit 60ba7f7 Author: wandmagic <[email protected]> Date: Fri Jan 10 11:15:47 2025 -0500 add inventory item constraints (GSA#1063) * add inventory item constraints * update example file Co-Authored-By: A.J. Stein <[email protected]> * improve scan type constraint * massage constraints * improve constraint content * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update fedramp-external-constraints.xml * Update fedramp-external-constraints.xml * Squashed commit of the following: commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) * Squashed commit of the following: commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) * Squashed commit of the following: commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) --------- Co-authored-by: A.J. Stein <[email protected]> Co-authored-by: Gabeblis <[email protected]> commit 5e3f386 Author: wandmagic <[email protected]> Date: Fri Jan 10 09:25:07 2025 -0500 make build (GSA#1080) commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (GSA#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (GSA#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (GSA#1085) commit 26f4f19 Author: ~ . ~ <[email protected]> Date: Wed Jan 8 11:06:00 2025 -0500 use latest server build commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (GSA#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (GSA#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit dd20034 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 22:21:48 2025 -0500 hotfix missing expect tag commit b4d3df5 Author: ~ . ~ <[email protected]> Date: Tue Jan 7 17:17:54 2025 -0500 use preview versions of oscal tools commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (GSA#1070) commit 719cf2c Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:12:47 2025 -0500 Add 'inventory-item-has-software-name' constraint and tests (GSA#1038) commit ec7affc Author: Gabeblis <[email protected]> Date: Tue Jan 7 13:11:13 2025 -0500 Add `inventory-item-has-software-version` constraint (GSA#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (GSA#1064) commit d8a9ec9 Author: DimitriZhurkin <[email protected]> Date: Fri Jan 3 11:20:23 2025 -0700 Add connection-security constraint (issue GSA#961) (GSA#1021) * Add connection-security constraint (issue GSA#961) * change fedramp ns to http * Add help-url commit 1648871 Author: Kylie Hunter <[email protected]> Date: Fri Jan 3 13:02:59 2025 -0500 Image has checksum (GSA#1053) * test scaffolds added * initial attempt at writing pass and fail content * feature file * revised target to appropriate place * removed old target * added in proper ns * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: A.J. Stein <[email protected]> * AJ suggestion for more complete example * added comments --------- Co-authored-by: A.J. Stein <[email protected]> commit 962a9c0 Author: Gabeblis <[email protected]> Date: Fri Jan 3 12:31:04 2025 -0500 Add 'inventory-item-or-component-has-asset-id' constraint and tests (GSA#1056) commit 836b224 Author: Rene Tshiteya <[email protected]> Date: Fri Jan 3 12:25:35 2025 -0500 Fix implemented-component component-uuid references (GSA#1059) Fix component issues commit 7018c20 Author: Gabeblis <[email protected]> Date: Fri Jan 3 12:24:47 2025 -0500 Add 'inventory-item-has-valid-mac-address' constraint and tests (GSA#1057)
* fix constraints (#1070) * use preview versions of oscal tools * hotfix missing expect tag * Add the inter-boundary-component-has-information-type constraint (#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml * Hotfix styles (#1076) * style guide hotfix * Update fedramp-external-constraints.xml * use latest server build * Correct constraint message. (#1085) * add additional sample content (#1081) * Add new metapath target to 'security-level' constraint (#1079) * make build (#1080) * add inventory item constraints (#1063) * add inventory item constraints * update example file Co-Authored-By: A.J. Stein <[email protected]> * improve scan type constraint * massage constraints * improve constraint content * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update src/validations/constraints/fedramp-external-constraints.xml Co-authored-by: Gabeblis <[email protected]> * Update fedramp-external-constraints.xml * Update fedramp-external-constraints.xml * Squashed commit of the following: commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (#1064) * Squashed commit of the following: commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (#1064) * Squashed commit of the following: commit 8c1a343 Author: Gabeblis <[email protected]> Date: Thu Jan 9 11:45:37 2025 -0500 Add new metapath target to 'security-level' constraint (#1079) commit 608080d Author: wandmagic <[email protected]> Date: Thu Jan 9 09:29:17 2025 -0500 add additional sample content (#1081) commit 1f55a73 Author: Gabeblis <[email protected]> Date: Thu Jan 9 09:22:28 2025 -0500 Correct constraint message. (#1085) commit 18a02c9 Author: wandmagic <[email protected]> Date: Wed Jan 8 09:37:15 2025 -0500 Hotfix styles (#1076) * style guide hotfix * Update fedramp-external-constraints.xml commit 60b3c50 Author: DimitriZhurkin <[email protected]> Date: Wed Jan 8 07:14:14 2025 -0700 Add the inter-boundary-component-has-information-type constraint (#1066) * Add the inter-boundary-component-has-information-type constraint * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml commit d7b0623 Author: wandmagic <[email protected]> Date: Tue Jan 7 14:47:44 2025 -0500 fix constraints (#1070) commit fc50a42 Author: wandmagic <[email protected]> Date: Fri Jan 3 14:21:47 2025 -0500 hotfix develop (#1064) --------- Co-authored-by: A.J. Stein <[email protected]> Co-authored-by: Gabeblis <[email protected]> * Add `inventory-item-has-software-version` constraint (#1039) * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-version' constraint and tests * Add 'inventory-item-has-software-name' constraint and tests (#1038) * use preview versions of oscal tools * hotfix missing expect tag * use latest server build * fix order and missing expect closing tag * Update fedramp-external-constraints.xml * use versions matrix for snapshot testing This reverts commit 5679abd. * better action names * Update module.mk * Update .tool-versions --------- Co-authored-by: DimitriZhurkin <[email protected]> Co-authored-by: Gabeblis <[email protected]> Co-authored-by: A.J. Stein <[email protected]>
Committer Notes
constraints for
#1044
#1045
#1046
#1047
#1054
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.