Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Example SSP to Pass Tests #1100

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to fix our example ssp (fedramp-ssp-example.oscal.xml) as there are two errors that cause the control-implementation-status constraint to fail. This error was caused by merging PR's, that passed all the GHA, in rapid succession and tests were not rerun after one PR was merged, resulting in erroneous content being added in the following PR.

Changes

  • Changed all occurrences implementation status state "operational" to "implemented" in order to align with the allowed values.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? Not applicable.
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Jan 15, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner January 15, 2025 17:13
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, I had not completed a review before merge on this very change because I was too slow to match you all. Nice catch.

@wandmagic wandmagic merged commit 144785b into GSA:develop Jan 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants