06/26/2024 Production Deploy

[ccostino]

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This is our production deploy for 6/26/2024. Full release notes can be viewed here!

Security Considerations

• All changes have been reviewed and tested prior to being included here.

[github-actions]

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.redis.data.cloudfoundry_service.redis: Reading...
module.domain.data.cloudfoundry_service.external_domain: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Read complete after 0s [id=9bd7f50c-8c53-4277-8839-9af17f8bca40]
module.domain.data.cloudfoundry_service.external_domain: Read complete after 0s [id=ef75a1d4-3d69-4deb-8704-626a36d02a93]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.redis.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=c3f1065e-aca4-45ba-9749-56391f028d44]
module.domain.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.domain.data.cloudfoundry_app.app: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e4972b9-c75d-4a84-927f-de4ec17a30d3]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 1s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=f6215fcd-2784-455d-bb4c-29570c03d284]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=3402a08a-fdec-c6ce-af28-b378e2ec4a32]
module.domain.data.cloudfoundry_app.app: Read complete after 1s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.cloudfoundry_route.origin_route: Refreshing state... [id=a9b8f112-116d-44bb-938e-192db047667e]
module.domain.cloudfoundry_service_instance.external_domain_instance: Refreshing state... [id=ab3354f3-4c3c-4979-852b-357878bd955e]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.redis-v70.cloudfoundry_service_instance.redis will be created
  + resource "cloudfoundry_service_instance" "redis" {
      + id                             = (known after apply)
      + json_params                    = jsonencode(
            {
              + engineVersion = "7.0"
            }
        )
      + name                           = "notify-admin-redis-v70-production"
      + replace_on_params_change       = false
      + replace_on_service_plan_change = false
      + service_plan                   = "39e035d8-f847-4bf5-a2ee-521c3118cc42"
      + space                          = "4447d89a-9735-4d82-94e1-dc07713aa460"
      + tags                           = []
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on .terraform/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 2 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

[github-actions]

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.redis.data.cloudfoundry_service.redis: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e384e68-c487-4645-af82-17b91c46ce05]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=5e7cbb6b-81b7-4f5f-9b55-fd11a62fe5e9]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=e4752004-ae2c-4b0f-bdf5-4a0c359fbfb9]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=4d29c834-baf5-4733-8034-41a764cde950]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=f016d719-5e07-2f05-7865-50a3c10be0a1]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.redis-v70.cloudfoundry_service_instance.redis will be created
  + resource "cloudfoundry_service_instance" "redis" {
      + id                             = (known after apply)
      + json_params                    = jsonencode(
            {
              + engineVersion = "7.0"
            }
        )
      + name                           = "notify-admin-redis-v70-demo"
      + replace_on_params_change       = false
      + replace_on_service_plan_change = false
      + service_plan                   = "39e035d8-f847-4bf5-a2ee-521c3118cc42"
      + space                          = "0b28b133-9f7b-49f1-9f34-a179cbb2549f"
      + tags                           = []
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.logo_upload_bucket.cloudfoundry_service_instance.bucket,
  on .terraform/modules/logo_upload_bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and one more similar warning elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

[jskinne3]

The terraform changes are as I expect