Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

06/26/2024 Production Deploy #2 #1661

Merged
merged 6 commits into from
Jun 26, 2024
Merged

06/26/2024 Production Deploy #2 #1661

merged 6 commits into from
Jun 26, 2024

Conversation

ccostino
Copy link
Contributor

@ccostino ccostino commented Jun 26, 2024

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This is a second production deploy for 6/26/2024. Full release notes can be viewed here!

Security Considerations

  • All changes have been reviewed and tested prior to being included here.

Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.redis.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e384e68-c487-4645-af82-17b91c46ce05]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=a1c6e6bb-775d-4bd8-ae03-5a045048a31f]
module.redis.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=5e7cbb6b-81b7-4f5f-9b55-fd11a62fe5e9]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 1s [id=4d29c834-baf5-4733-8034-41a764cde950]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=e4752004-ae2c-4b0f-bdf5-4a0c359fbfb9]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=f016d719-5e07-2f05-7865-50a3c10be0a1]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.logo_upload_bucket.cloudfoundry_service_instance.bucket,
  on .terraform/modules/logo_upload_bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and one more similar warning elsewhere)

Pusher: @ccostino, Action: pull_request

Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.redis.data.cloudfoundry_service.redis: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_service.external_domain: Reading...
module.domain.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Read complete after 0s [id=9bd7f50c-8c53-4277-8839-9af17f8bca40]
module.domain.data.cloudfoundry_service.external_domain: Read complete after 0s [id=ef75a1d4-3d69-4deb-8704-626a36d02a93]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=c3f1065e-aca4-45ba-9749-56391f028d44]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e4972b9-c75d-4a84-927f-de4ec17a30d3]
module.domain.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.domain.data.cloudfoundry_app.app: Reading...
module.api_network_route.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=c687eb81-62cb-4aa0-b93d-ce19a10916fa]
module.domain.data.cloudfoundry_app.app: Read complete after 0s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.cloudfoundry_route.origin_route: Refreshing state... [id=a9b8f112-116d-44bb-938e-192db047667e]
module.domain.cloudfoundry_service_instance.external_domain_instance: Refreshing state... [id=ab3354f3-4c3c-4979-852b-357878bd955e]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=f6215fcd-2784-455d-bb4c-29570c03d284]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=3402a08a-fdec-c6ce-af28-b378e2ec4a32]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on .terraform/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 2 more similar warnings elsewhere)

Pusher: @ccostino, Action: pull_request

Copy link
Contributor

@jskinne3 jskinne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful indentation ✨

@ccostino ccostino merged commit 3dc828f into production Jun 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants