Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7/24/2024 Production Deploy #1765

Merged
merged 73 commits into from
Jul 25, 2024
Merged

7/24/2024 Production Deploy #1765

merged 73 commits into from
Jul 25, 2024

Conversation

ccostino
Copy link
Contributor

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This is a production deploy for 7/24/2024. Full release notes are here!

Security Considerations

  • All changes have been reviewed and tested prior to being included here.

Kenneth Kehl and others added 30 commits June 10, 2024 10:53
Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_service.external_domain: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Read complete after 0s [id=9bd7f50c-8c53-4277-8839-9af17f8bca40]
module.domain.data.cloudfoundry_service.external_domain: Read complete after 0s [id=ef75a1d4-3d69-4deb-8704-626a36d02a93]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e4972b9-c75d-4a84-927f-de4ec17a30d3]
module.domain.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.domain.data.cloudfoundry_app.app: Reading...
module.api_network_route.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.redis-v70.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=17e1e72f-74ef-459d-9bf1-3c5c8f44c00a]
module.domain.data.cloudfoundry_app.app: Read complete after 1s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.cloudfoundry_route.origin_route: Refreshing state... [id=a9b8f112-116d-44bb-938e-192db047667e]
module.domain.cloudfoundry_service_instance.external_domain_instance: Refreshing state... [id=ab3354f3-4c3c-4979-852b-357878bd955e]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=f6215fcd-2784-455d-bb4c-29570c03d284]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 1s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=3402a08a-fdec-c6ce-af28-b378e2ec4a32]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.prevent_destroy will be created
  + resource "null_resource" "prevent_destroy" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on .terraform/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.api_network_route.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e384e68-c487-4645-af82-17b91c46ce05]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=a1c6e6bb-775d-4bd8-ae03-5a045048a31f]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=e4752004-ae2c-4b0f-bdf5-4a0c359fbfb9]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=4d29c834-baf5-4733-8034-41a764cde950]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=f016d719-5e07-2f05-7865-50a3c10be0a1]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.prevent_destroy will be created
  + resource "null_resource" "prevent_destroy" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

heyitsmebev
heyitsmebev previously approved these changes Jul 24, 2024
Copy link
Contributor

@heyitsmebev heyitsmebev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…lates-to-table-on-dashboard

Fixed KeyError on processing_finished and removed notification api call
Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=a1c6e6bb-775d-4bd8-ae03-5a045048a31f]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e384e68-c487-4645-af82-17b91c46ce05]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=e4752004-ae2c-4b0f-bdf5-4a0c359fbfb9]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 1s [id=4d29c834-baf5-4733-8034-41a764cde950]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=f016d719-5e07-2f05-7865-50a3c10be0a1]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.prevent_destroy will be created
  + resource "null_resource" "prevent_destroy" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.redis-v70.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Reading...
module.domain.data.cloudfoundry_service.external_domain: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Read complete after 1s [id=9bd7f50c-8c53-4277-8839-9af17f8bca40]
module.domain.data.cloudfoundry_service.external_domain: Read complete after 1s [id=ef75a1d4-3d69-4deb-8704-626a36d02a93]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=17e1e72f-74ef-459d-9bf1-3c5c8f44c00a]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.domain.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.domain.data.cloudfoundry_app.app: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e4972b9-c75d-4a84-927f-de4ec17a30d3]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=f6215fcd-2784-455d-bb4c-29570c03d284]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=3402a08a-fdec-c6ce-af28-b378e2ec4a32]
module.domain.data.cloudfoundry_app.app: Read complete after 1s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.cloudfoundry_route.origin_route: Refreshing state... [id=a9b8f112-116d-44bb-938e-192db047667e]
module.domain.cloudfoundry_service_instance.external_domain_instance: Refreshing state... [id=ab3354f3-4c3c-4979-852b-357878bd955e]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.prevent_destroy will be created
  + resource "null_resource" "prevent_destroy" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on .terraform/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

don't allow commas in placeholder fields
Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.domain.data.cloudfoundry_domain.origin_url: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.domain.data.cloudfoundry_service.external_domain: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Read complete after 0s [id=9bd7f50c-8c53-4277-8839-9af17f8bca40]
module.domain.data.cloudfoundry_service.external_domain: Read complete after 0s [id=ef75a1d4-3d69-4deb-8704-626a36d02a93]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e4972b9-c75d-4a84-927f-de4ec17a30d3]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=17e1e72f-74ef-459d-9bf1-3c5c8f44c00a]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.domain.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.domain.data.cloudfoundry_app.app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=f6215fcd-2784-455d-bb4c-29570c03d284]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=3402a08a-fdec-c6ce-af28-b378e2ec4a32]
module.domain.data.cloudfoundry_app.app: Read complete after 1s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.cloudfoundry_route.origin_route: Refreshing state... [id=a9b8f112-116d-44bb-938e-192db047667e]
module.domain.cloudfoundry_service_instance.external_domain_instance: Refreshing state... [id=ab3354f3-4c3c-4979-852b-357878bd955e]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.prevent_destroy will be created
  + resource "null_resource" "prevent_destroy" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on .terraform/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=a1c6e6bb-775d-4bd8-ae03-5a045048a31f]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e384e68-c487-4645-af82-17b91c46ce05]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=4d29c834-baf5-4733-8034-41a764cde950]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=e4752004-ae2c-4b0f-bdf5-4a0c359fbfb9]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=f016d719-5e07-2f05-7865-50a3c10be0a1]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.prevent_destroy will be created
  + resource "null_resource" "prevent_destroy" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

@stvnrlly stvnrlly merged commit f6dc5c5 into production Jul 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants