-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set timezone automatically #1901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ken, I left a couple of comments related to the js scripts placement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Set the timezone automatically for the user based on what the browser says the timezone is.
We were using US/Eastern and 7 or 8 similar timezones to represent the US, but it turns out these are "legacy" timezones and the correct forward-leaning timezones all look like "America/Los_Angeles". These work fine for scheduling jobs and so forth, but just look a little different.
Since are going to be setting the timezone automatically, the user will not have the option to set their timezone to something else, so I suppose we need to remove the Change Timezone feature on the User Profile.
TODO (optional)
Security Considerations
N/A