Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2200 - Adding tooltip to Total messages header for explanation #2273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonathanbobel
Copy link
Contributor

@jonathanbobel jonathanbobel commented Jan 17, 2025

Description

Users are confused as to what Total messages are/is in the Dashboarding. Adding a tooltip to help explain.

TODO (optional)

  • Integrate the USWDS tooltip into the project, and allow it to be used elsewhere and not just in this specific scenario
  • Add tooltip to Total messages header
  • Accessibility testing

line-height: units(1);
}
}
// .usa-tooltip {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comment if we don't need it anymore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi! i saw that my review is requested for this, and i'm wondering where i might find a screen capture of it. thank you! tho i do appreciate the clarity of .usa-tooltip being added

Copy link
Contributor

@heyitsmebev heyitsmebev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heyitsmebev heyitsmebev requested review from dmvancura and removed request for dmvancura January 21, 2025 23:15
Copy link

@dmvancura dmvancura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a screen capture possible so i may see these changes? thank you much @jonathanbobel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants