redis report #2289
redis report #2289
Conversation
There was a problem hiding this comment.
This is awesome to see and will be very useful, thanks @terrazoon!
I have the same note about the black/isort changes here in that we can't include them in the CI/CD pipeline like that (but we can work them in locally and just make sure folks do that!), and a quick question about the additional environment checks.
app/main/views/platform_admin.py
Outdated
| writer.writerow(["", "Max Memory", max_memory]) | ||
| writer.writerow(["", "Memory Fragmentation Ratio", mem_fragmentation]) | ||
| writer.writerow(["", "Memory Fragmentation Quality", frag_quality, frag_note]) | ||
| #writer.writerow(["", "Memory Fragmentation Note", frag_note]) |
There was a problem hiding this comment.
I see the fragmentation note is included in the line above - can we just get rid of this one?
| #writer.writerow(["", "Memory Fragmentation Note", frag_note]) |
| @@ -68,11 +68,12 @@ def _get_access_token(code): # pragma: no cover | |||
| id_token = get_id_token(response_json) | |||
| nonce = id_token["nonce"] | |||
| nonce_key = f"login-nonce-{unquote(nonce)}" | |||
| stored_nonce = redis_client.get(nonce_key).decode("utf8") | |||
| if not os.getenv("NOTIFY_ENVIRONMENT") == "development": | |||
There was a problem hiding this comment.
I see there an additional check here and below for the environment to see that it's not development - just double checking what this is accounting for that's specific to the development environment as I'm not remembering. :-)
There was a problem hiding this comment.
When I try to run it locally, it almost always fails here and I end up having to comment out the code in order to work.
Co-authored-by: Carlo Costino <[email protected]>
Description
Add a Redis report to the platform admin area. Also, change the checks.yml so isort and black are run before file checks so style checks NEVER FAIL AGAIN when you push a PR.
Security Considerations
N/A