Production deploy 11/29/23 #950

stvnrlly · 2023-11-28T19:35:27Z

No description provided.

…o 803-keep-current-service-visible

- Changing route back to - instead of _ so it won't break tests, also it was a mistake

- Fixed test for using-notify broken link

…o 803-keep-current-service-visible

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.20 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

…o 803-keep-current-service-visible

…create user

…o 800-combine-and-style-quota-displays

…o 801-send-message-button

…o 847-change-blanket-error-message # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

The new release of flake8-bugbear is starting to flag positional argument unpacking that comes after keyword arguments in function calls as a style warning that fails. This is a good thing to catch because it can lead to unexpected side effects with function arguments and/or errors thrown by Python. See the following links for more details: - https://stackoverflow.com/questions/58961715/python-value-unpacking-order-in-method-parameters - python/cpython#82741 This changeset fixes a couple of instances where the positional argument unpacking was happening after keyword arguments were being provided. Signed-off-by: Carlo Costino <[email protected]>

Bumps [pytest-env](https://github.com/pytest-dev/pytest-env) from 1.1.1 to 1.1.3. - [Release notes](https://github.com/pytest-dev/pytest-env/releases) - [Commits](pytest-dev/pytest-env@1.1.1...1.1.3) --- updated-dependencies: - dependency-name: pytest-env dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bump pytest-env from 1.1.1 to 1.1.3

Adjust positional arguments flagged by flake8-bugbear

Bumps [flake8-bugbear](https://github.com/PyCQA/flake8-bugbear) from 23.9.16 to 23.11.28. - [Release notes](https://github.com/PyCQA/flake8-bugbear/releases) - [Commits](PyCQA/flake8-bugbear@23.9.16...23.11.28) --- updated-dependencies: - dependency-name: flake8-bugbear dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump flake8-bugbear from 23.9.16 to 23.11.28

tdlowden · 2023-11-29T15:31:44Z

Manual QA Checklist

Log-in

notify-staging.app.cloud.gov resolves
Clicking sign in takes you to login page
2FA code is sent promptly
2FA code input screen appears as expected
After code is entered, you are brought to the “choose service” screen
Choosing a service brings you to the dashboard for that service

Create a template and send

Clicking “Send messages” brings you to templates page
When “Create a template” button is clicked, the option to create new or copy existing template appears
Uploading a csv is quick and automatically directs you to the preview/send page
Formatting looks clean and in place
Message dashboard populates and shows “pending” until call is made to AWS for delivery receipt

Send a message from copied template

When “Create a template” button is clicked, the option to create new or copy existing template appears
Clicking “copy an existing template” allows you to choose from pre-existing template
After editing, the new template saves and you prepare to send

Send a message from existing template

Clicking on existing template brings you to preview screen with prepare to send button
All else above persists as true (formatting, send, dashboard, etc)

Download the csv delivery report

Clicking on the csv download directly after a message send downloads a report that contains the data we expect
Clicking on the csv download link from the 7-day aggregated dashboard downloads a report that contains the data we expect

Invite a team member

Clicking on “Team Members” in left nav brings you to team member screen
Clicking “Invite a team member” brings you to email and permissions screen
Clicking invite team member sends an invite and shows confirmation
Invite email provides live link that works to register new team member

Delete a team member

From team member screen, clicking “Change Details” on a specific profile brings you to that person’s profile
Clicking on “Remove this team member” prompts a confirmation
Clicking the confirmation removes the team member

Sign out

Hitting “Sign Out” takes you back to the homepage and logs you out
This does not happen exactly. You are logged out, but the sign out link takes tou to a Page Not Found error at /None instead of going to the homepage. I am going to approve regardless

tdlowden

QA passes with a small hiccup on sign out. Noted in comments.

maybe fix 404 on signout

tdlowden

thanks for the sign out fix, @terrazoon !

Andrew Shumway and others added 30 commits October 6, 2023 11:41

Remove notify from senders message flow

7ec9a5a

Committing before merge

3e7a4f7

Merge branch 'main' of https://github.com/GSA/notifications-admin int…

988c1e9

…o 803-keep-current-service-visible

- Updated navigation file to show active atate in top nav

3106b85

- Changing route back to - instead of _ so it won't break tests, also it was a mistake

- Updated nav to allow for the active state throughout Service sub-nav

167023c

- Fixed test for using-notify broken link

Merge branch 'main' of https://github.com/GSA/notifications-admin int…

07f9255

…o 803-keep-current-service-visible

Adding nav item for platform admin as well

a34ab8c

Slight change from caps to lowercase

195af62

initial for login.gov integration

86ac810

Merge branch 'main' of https://github.com/GSA/notifications-admin int…

1ad3d87

…o 803-keep-current-service-visible

cleanup login.gov work

1d1e774

work on logout

7ca258b

fiddle with logout

782cff2

Content update for blanket error page

1271098

801 - Moving Send message link from inside the side nav to a button

5304c0f

notify-admin-571 add platform_admin condition for create service and …

222c83e

…create user

Fixing tests

c290e60

notify-admin-866 improve tests with noqa comments

90025de

more fixes

bd2ea81

more tests

8c9acad

fix remaining tests

b487a91

merge from main

899027b

merge from main

622bdd4

800 - combining and updating the wording around messages remaining

0cc91b4

Merge branch 'main' of https://github.com/GSA/notifications-admin int…

c695b59

…o 800-combine-and-style-quota-displays

Merge branch 'main' of https://github.com/GSA/notifications-admin int…

f4048d5

…o 801-send-message-button

Changing the layout of the page to a table view

0a11211

merge from main

1d79086

stvnrlly temporarily deployed to staging November 29, 2023 14:26 — with GitHub Actions Inactive

stvnrlly temporarily deployed to staging November 29, 2023 14:30 — with GitHub Actions Inactive

ccostino and others added 3 commits November 29, 2023 09:39

Merge pull request #955 from GSA/dependabot/pip/pytest-env-1.1.3

fa90eb0

Bump pytest-env from 1.1.1 to 1.1.3

ccostino temporarily deployed to staging November 29, 2023 14:52 — with GitHub Actions Inactive

Merge pull request #953 from GSA/fix-positional-arguments

f392c67

Adjust positional arguments flagged by flake8-bugbear

stvnrlly temporarily deployed to staging November 29, 2023 14:55 — with GitHub Actions Inactive

ccostino temporarily deployed to staging November 29, 2023 14:57 — with GitHub Actions Inactive

stvnrlly temporarily deployed to staging November 29, 2023 15:00 — with GitHub Actions Inactive

dependabot bot and others added 2 commits November 29, 2023 15:04

Merge pull request #957 from GSA/dependabot/pip/flake8-bugbear-23.11.28

8fed8b9

Bump flake8-bugbear from 23.9.16 to 23.11.28

ccostino temporarily deployed to staging November 29, 2023 15:12 — with GitHub Actions Inactive

ccostino temporarily deployed to staging November 29, 2023 15:16 — with GitHub Actions Inactive

tdlowden requested review from tdlowden and ccostino November 29, 2023 15:45

tdlowden previously approved these changes Nov 29, 2023

View reviewed changes

Kenneth Kehl and others added 2 commits November 29, 2023 10:24

maybe fix 404 on signout

417c072

Merge pull request #959 from GSA/fix_404_maybe

4f9a89d

maybe fix 404 on signout

ccostino dismissed tdlowden’s stale review via 4f9a89d November 29, 2023 19:00

ccostino temporarily deployed to staging November 29, 2023 19:00 — with GitHub Actions Inactive

ccostino temporarily deployed to staging November 29, 2023 19:05 — with GitHub Actions Inactive

tdlowden self-requested a review November 29, 2023 19:21

tdlowden approved these changes Nov 29, 2023

View reviewed changes

stvnrlly merged commit f926cf0 into production Nov 29, 2023
8 checks passed

stvnrlly changed the title ~~Production deploy 11/28/23~~ Production deploy 11/29/23 Nov 29, 2023

rahearn temporarily deployed to demo November 30, 2023 12:02 — with GitHub Actions Inactive

rahearn temporarily deployed to production November 30, 2023 12:02 — with GitHub Actions Inactive

rahearn temporarily deployed to staging November 30, 2023 12:02 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Production deploy 11/29/23 #950

Production deploy 11/29/23 #950

stvnrlly commented Nov 28, 2023

tdlowden commented Nov 29, 2023 •

edited

Loading

tdlowden left a comment

tdlowden left a comment

Production deploy 11/29/23 #950

Production deploy 11/29/23 #950

Conversation

stvnrlly commented Nov 28, 2023

tdlowden commented Nov 29, 2023 • edited Loading

Manual QA Checklist

tdlowden left a comment

Choose a reason for hiding this comment

tdlowden left a comment

Choose a reason for hiding this comment

tdlowden commented Nov 29, 2023 •

edited

Loading