Merge pull request #698 from GSA/API-683_Make_UI_and_Reports_Reflect_…

…Opt_Out_Numbers Api 683 make UI and reports reflect opt out numbers
GSA · Jan 2, 2024 · d14120a · d14120a
2 parents e01bcaa + 976d57b
commit d14120a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/clients/cloudwatch/aws_cloudwatch.py b/app/clients/cloudwatch/aws_cloudwatch.py
@@ -127,7 +127,7 @@ def check_sms(self, message_id, notification_id, created_at):
             return (
                 "failure",
                 message["delivery"]["providerResponse"],
-                message["delivery"]["phoneCarrier"],
+                message["delivery"].get("phoneCarrier", "Unknown Carrier"),
             )
 
         if time_now > (created_at + timedelta(hours=3)):

diff --git a/migrations/versions/0409_fix_service_name.py b/migrations/versions/0409_fix_service_name.py
@@ -27,7 +27,8 @@ def upgrade():
     # select_by_val = service_id
     input_params = {"service_id": service_id}
     conn.execute(
-        text("update services set name='Notify.gov' where id =:service_id"), input_params
+        text("update services set name='Notify.gov' where id =:service_id"),
+        input_params,
     )
 
     # table_name = 'services_history'