-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.6.0.beta.1 (Sprint 37) #1657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or alert inline with this itteration
… based on required fields and values
…x translations for fieldset component
…A/px-benefit-finder into 1513-inline-input-error-msg
…date merged radio elements on error
…px-benefit-finder into 1643-error-design-updates
…t-finder into 1635-init-script
1635 init script
…etup PXBF-1641-allow-custom-branch-checkout-setup: split the param and the…
1643 error design updates
1043 update select content
…-validation 1651 include radio groups with error validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Related Github Issue
Application Improvements
Error Alert Design Updates #1643
Determine consistent translation for inline field errors #1555
Include additional text to resolve form field errors with fields #1513
Include a list of links to the fields that have errors in alerts #1512
Include error count in alert #1511
Data Layer Improvements
Create data layer event(s) to track error messages in analytics #1501
Content Improvements
Change "Click to select" in SP combo box #1043
Custom Module Improvements
Error Label Content Override #1614
Detailed Testing steps
Application Improvements
Error Alert Design Updates #1643
/death
Continue
expected:
![Screenshot 2024-08-08 at 10 13 18 AM](https://private-user-images.githubusercontent.com/37077057/356257319-3dc9681d-2e63-442d-9b60-987ca2bbfdda.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzYwNDYsIm5iZiI6MTczOTM3NTc0NiwicGF0aCI6Ii8zNzA3NzA1Ny8zNTYyNTczMTktM2RjOTY4MWQtMmU2My00NDJkLTliNjAtOTg3Y2EyYmJmZGRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE1NTU0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAyZTc2ZDNjNzM1N2Y3YzA3YzEzN2I0YjNlNDEzMjBjNDljM2FkZDllNGM0M2ZiNzk5MTE1ZTlmMThhYTMyZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bOMVu10Gb1-S7rEmJY8FyuWeZdDLHGEsUJu_4_PCy0A)
Include error count in alert #1511
Include a list of links to the fields that have errors in alerts #1512
Include additional text to resolve form field errors with fields #1513
Determine consistent translation for inline field errors #1555
bf-error-detail
field that indicates to the user to "fill out the {legend} field"Expected:
![Screenshot 2024-08-01 at 3 56 29 PM](https://private-user-images.githubusercontent.com/37077057/354365173-8e2867d6-4ed2-486c-a0c5-6f3d6ab5bcf8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzYwNDYsIm5iZiI6MTczOTM3NTc0NiwicGF0aCI6Ii8zNzA3NzA1Ny8zNTQzNjUxNzMtOGUyODY3ZDYtNGVkMi00ODZjLWEwYzUtNmYzZDZhYjViY2Y4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE1NTU0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTljYzM0NDZiY2I4ZmM4MzU4Mzg3ZDBkZTM2NTc2OTkzNTRkZWE3Y2QyY2E1NjE1MDY0ZjY4MGMwZWFmOWU0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.1Apknzpr-zU8EtbdnMg4hIBcCbaCfEKsRzA77cA0ZjU)
en locale
<fieldset />
is removedContent Improvements
Change "Click to select" in SP combo box #1043
/death
<select/>
's have the following default labels and configurationen
Data Improvements
Create data layer event(s) to track error messages in analytics #1501
/death
bf_form_page_submit_attempt
is in the dataLayerfalse
expected structure:
Continue
bf_form_page_submit_attempt
is in the dataLayer0
true
expected structure:
Custom Module Improvements
Error Label Content Override #1614
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
Error Message
fieldbenefit-finder/api/life-event/death