Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6.0.beta.1 (Sprint 37) #1657

Merged
merged 192 commits into from
Aug 8, 2024
Merged

v0.6.0.beta.1 (Sprint 37) #1657

merged 192 commits into from
Aug 8, 2024

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented Aug 8, 2024

PR Summary

Related Github Issue

Application Improvements

Error Alert Design Updates #1643
Determine consistent translation for inline field errors #1555
Include additional text to resolve form field errors with fields #1513
Include a list of links to the fields that have errors in alerts #1512
Include error count in alert #1511

Data Layer Improvements

Create data layer event(s) to track error messages in analytics #1501

Content Improvements

Change "Click to select" in SP combo box #1043

Custom Module Improvements

Error Label Content Override #1614

Detailed Testing steps

Application Improvements

Error Alert Design Updates #1643

  • navigate to /death
  • CLICK start
  • without completing any fields, CLICK Continue
  • ensure new styling and layout for error alerts

expected:
Screenshot 2024-08-08 at 10 13 18 AM

Include error count in alert #1511
Include a list of links to the fields that have errors in alerts #1512
Include additional text to resolve form field errors with fields #1513
Determine consistent translation for inline field errors #1555

  • ensure the number of errors indicated in the alert is equal to the number of inputs/selects that have errors
Screenshot 2024-08-01 at 3 57 19 PM
  • ensure that the error banner has a list of error descriptions, which are links to each of the error fields
Screenshot 2024-08-01 at 3 57 15 PM
  • ensure that selecting the error link takes you to the field described and focus that field
  • ensure the fields with errors have red borders around them
  • ensure each error fieldset should have an accompanying bf-error-detail field that indicates to the user to "fill out the {legend} field"

Expected:
en locale
Screenshot 2024-08-01 at 3 56 29 PM

  • ensure that when you resolve this error the error border is removed
  • ensure that when all fields in a field group are resolved the error border on the <fieldset /> is removed
  • ensure that when you resolve an error the error description is removed from the error banner list
  • ensure that when you resolve an error the error count decreases
  • ensure that when all errors are resolved all error indicators are removed

Content Improvements

Change "Click to select" in SP combo box #1043

  • navigate to /death
  • CLICK start to navigate to first step of form
  • confirm that the <select/>'s have the following default labels and configuration

en

  "select": {
    "labelSelect": "Select an option",
    "defaultValue": "-Select-",
    ...
  },

Data Improvements

Create data layer event(s) to track error messages in analytics #1501

  • navigate to /death
  • CLICK continue without providing field values
  • confirm error banner is visible
  • console.log(window.dataLayer)
  • confirm bf_form_page_submit_attempt is in the dataLayer
  • confirm the event has a string of errors, that are the ids of the field values with errors
  • confirm the error count matches that presented in the UI
  • confirm that formSuccess is false

expected structure:

{
    "event": "bf_form_page_submit_attempt",
    "bfData": {
        "errors": "STRING, STRING, STRING,...",
        "errorCount": {
            "number": NUMBER,
            "string": "STRING"
        },
        "formSuccess": false
    }
}
  • resolve errors by providing values for required fields
  • CLICK Continue
  • console.log(window.dataLayer)
  • confirm a second bf_form_page_submit_attempt is in the dataLayer
  • confirm the event has an empty string of errors
  • confirm the error count is 0
  • confirm that formSuccess is true

expected structure:

{
    "event": "bf_form_page_submit_attempt",
    "bfData": {
        "errors": "",
        "errorCount": {
            "number": NUMBER,
            "string": "STRING"
        },
        "formSuccess": true
    }
}

Custom Module Improvements

Error Label Content Override #1614

  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Add "Input the date of birth" in Error Message field
  • Save as published
  • Navigate to benefit-finder/api/life-event/death
  • Verify errorMessage "Input the date of birth"

scottqueen-bixal and others added 30 commits June 27, 2024 14:21
…A/px-benefit-finder into 1513-inline-input-error-msg
scottqueen-bixal and others added 28 commits August 6, 2024 11:29
…px-benefit-finder into 1643-error-design-updates
…etup

PXBF-1641-allow-custom-branch-checkout-setup: split the param and the…
…-validation

1651 include radio groups with error validation
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review August 8, 2024 14:28
@scottqueen-bixal scottqueen-bixal merged commit 4e978ce into main Aug 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants