Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration action gsq #1693

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Integration action gsq #1693

merged 4 commits into from
Aug 16, 2024

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented Aug 16, 2024 •
edited
Loading

PR Summary

I've made some recommended changes based on the following considerations:

  • we are in the process of removing e2e component testing
  • our unit tests only runs against our JS code
  • since we already have the submodule, we can git switch to the working branch since it will already be on the submodule origin

Detailed Testing steps

@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review August 16, 2024 12:34
@scottqueen-bixal scottqueen-bixal self-assigned this Aug 16, 2024
@XavierMetichecchia XavierMetichecchia merged commit 697c814 into dev Aug 16, 2024
8 of 11 checks passed
@XavierMetichecchia XavierMetichecchia deleted the integration-action-gsq branch August 16, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierMetichecchia XavierMetichecchia Awaiting requested review from XavierMetichecchia

Assignees

@scottqueen-bixal scottqueen-bixal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottqueen-bixal @XavierMetichecchia