Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2089 fix nested child errors #2092

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jan 29, 2025

PR Summary

fixes issue with including hidden child required fields in error array

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • cd benefit-finder
  • npm install
  • npm run dev:storybook
  • navigate to localhost:6000
  • open App component
  • navigate to first step
  • CLICK next
  • ensure error alert only shows visible required fields
  • input date <18years
  • resolve all other required fields
  • CLICK next
  • ensure step 2 renders
  • CLICK back
  • update date value to >=18years
  • ensure child criteria displays
  • CLICK next
  • ensure child criteria error is in alert
  • resolve error
  • CLICK next
  • ensure step 2 renders
  • CLICK back
  • input date <18years
  • ensure child criteria is not displayed
  • input date >=18years
  • ensure child criteria values are cleared

expected:

Screen.Recording.2025-01-29.at.8.46.51.AM.mov

@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review January 29, 2025 14:00
@scottqueen-bixal scottqueen-bixal self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

child criteria is required cause error
1 participant