Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error hidden #957

Merged
merged 3 commits into from
Mar 1, 2024
Merged

fix error hidden #957

merged 3 commits into from
Mar 1, 2024

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented Feb 28, 2024 •
edited by nehemiah-abuga
Loading

PR Summary

This works to pass error state for both aria-live and aria-hidden values making it accessible to screen readers

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • npm install
  • npm run start
  • turn voice over on
  • navigate through first step without entry
  • click continue
  • note if error takes focus
  • note if error is announced to voice over
  • tab
  • note if inline error takes focus
  • note if error is announced to voice over
  • turn voiceover off
  • inspect the DOM
  • refresh the page
  • find error in DOM
  • note if aria-live="polite"
  • note if aria-hidden="true"
  • navigate through first step without entry
  • click continue
  • find error in DOM
  • note if aria-live="assertive"
  • note if aria-hidden="false"

Expected:

error-visible.mp4

@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review February 28, 2024 20:14
@scottqueen-bixal scottqueen-bixal self-assigned this Feb 28, 2024
nehemiah-abuga
nehemiah-abuga approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified this change. Approved.

ally-error-hidden.mp4

@scottqueen-bixal scottqueen-bixal merged commit f4bfd4b into dev Mar 1, 2024
9 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 956-fix-error-hidden branch March 1, 2024 14:07
@scottqueen-bixal scottqueen-bixal mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehemiah-abuga nehemiah-abuga nehemiah-abuga approved these changes

Assignees

@scottqueen-bixal scottqueen-bixal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Alert hidden
2 participants
@scottqueen-bixal @nehemiah-abuga