Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sr label "not completed" in step indicator #958

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented Feb 28, 2024

PR Summary

This works to ensure that "not completed" is announced based on the completed status of the step.

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • npm install
  • npm run start
  • turn voice over on
  • navigate to first step, step nav
  • note if two items are listed as "not-complete"
  • compete required fields
  • navigate to second step, step nav
  • note if two items are listed, first as "completed", second as "not completed"
  • navigate back to the first step
  • navigate to the first step, step nav
  • note if two items are listed, first as "completed", second as "not completed"

Expected:

error-step-nav-not-completed.mp4

@scottqueen-bixal scottqueen-bixal self-assigned this Feb 28, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review February 28, 2024 20:47
@scottqueen-bixal scottqueen-bixal changed the title update sr label "not-completed" in step indicator update sr label "not completed" in step indicator Feb 28, 2024
@nehemiah-abuga
Copy link
Contributor

@scottqueen-bixal - After I complete the required fields, VoiceOVer still says not completed

not-completed.mp4

@scottqueen-bixal
Copy link
Contributor Author

@scottqueen-bixal - After I complete the required fields, VoiceOVer still says not completed

not-completed.mp4

This is expected behavior. We don't confirm that a step is complete until the user has selected "continue" and navigated to the next step.

It appears in the video that you didn't navigate to the second step. Did you have trouble going forward?

Copy link
Contributor

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified this after pressing the continue button. Approved

@scottqueen-bixal scottqueen-bixal merged commit e16c22e into dev Mar 4, 2024
6 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 933-update-sr-label branch March 4, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen Reader "Deceased" Pronounced Incorrectly
2 participants